Open
Conversation
Member
Author
|
@StrongKs @SeanHersh @resetdisconnect could you check that this branch installs and works on your machines? Feel free to experiment with the benchmark script but be cautious with the larger |
Member
Author
|
This change requires a unit test, and in designing one i observed something strange. With v1.0.0 installed, the following code detects differences only for # equilateral triangle
a <- rbind(
c(0,0),
c(sqrt(3)/2,.5),
c(sqrt(3)/2,-.5)
)
d <- dist(round(a, digits = 15))
p <- as.data.frame(vietoris_rips(d))
p$death[1:2] == 1
p$death[1:2] - 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
value_ttype andratioparameter from float to double.Benchmark comparisons on small and medium data sets incurred no consistent cost to storage or runtime.
Coordinated with this
ripserqPR.