record censored death values as missing rather than infinite#45
Open
corybrunson wants to merge 4 commits intomainfrom
Open
record censored death values as missing rather than infinite#45corybrunson wants to merge 4 commits intomainfrom
corybrunson wants to merge 4 commits intomainfrom
Conversation
Member
Author
|
@StrongKs @SeanHersh @resetdisconnect could you check that this branch installs and works on your machines? Feel free to experiment with the benchmark script but be cautious with the larger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR revises the C++ source code to record death values beyond the threshold ("censored" deaths) as not-a-number rather than infinite and replace these with the missing double value
Rcpp::NA_REAL(which corresponds toNA_real_) while populating theRcpp::NumericMatrix.The reason for taking two steps is that the
std::vectorstorage of the persistent pairs cannot accommodateRcpp::NA_REAL. One alternative would be to collect persistent pairs in aRcpp::NumericMatrixthroughout. Benchmark comparisons showed this option to incur significantly higher storage and runtime costs.Coordinated with this
ripserqPR.