Remove oga benchmark for amazon plugin#1314
Merged
Merged
Conversation
The oga project has been archived, so drop the benchmark that compared the oga parser against rexml. It referenced AmazonItem, which was already removed when the amazon plugin migrated to PA-API, so the benchmark no longer ran. Also remove its now-unused fixture. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR removes an obsolete benchmark setup for the Amazon plugin that relied on the archived oga project, along with its associated Amazon ECS XML fixture.
Changes:
- Delete the Amazon plugin benchmark script that compared
rexmlvsoga. - Remove the large Amazon ECS XML response fixture that was only used by that benchmark.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/fixtures/jpB00H91KK26.xml | Removes the Amazon ECS XML fixture that supported the deleted benchmark. |
| benchmark/benchmark_amazon_plugin.rb | Removes the oga vs rexml benchmark for the Amazon plugin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ogaproject has been archived