Open
Conversation
andycate
requested review from
BBScholar,
emmaworley,
nicholasunderwood and
rphlhuang
| @@ -0,0 +1,21 @@ | |||
| //const $ = require('jquery'); // eslint-disable-line no-unused-vars | |||
There was a problem hiding this comment.
I don't know what this line was supposed to do, but it was raising an error. I added jquery. It works fine without it
src/renderer.js
Outdated
| $('#coords').text('(' + x + ', ' + y + ')'); | ||
| }); | ||
|
|
||
| $('body').click(createPoint); |
There was a problem hiding this comment.
The goal here was (eventually) store the points, take a constant interval value, and generate points in real time. I don't know how memory intensive this will be, and we might want to implement a button to generate the path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should have everything needed to get started. I am not sure how development will work on windows yet because I don't know if Electron will work with WSL.