Conversation
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=========================================
Coverage 33.21% 33.21%
Complexity 28 28
=========================================
Files 8 8
Lines 277 277
Branches 41 41
=========================================
Hits 92 92
Misses 173 173
Partials 12 12Continue to review full report at Codecov.
|
andycate
left a comment
andycate
left a comment
There was a problem hiding this comment.
This looks really good so far. There are definitely things that need to be added though. First off, when widgets are moved around, the final arrangement and size of widgets should be saved in the config settings. Second, when the window is resized, the widgets should stay the same size, but wrap accordingly. Right now, I see this when I resize the page:
Also, I feel like there should be a button in the title bar of each widget that is explicitly for clicking and dragging. For example here:
Also, I feel like the padding around the widgets should be smaller. And it should be constant when the page is resized. The part in red should be smaller:
Also, in the settings Modals, there should be more padding. For reference, look at the picture below:
| if(widgetX>29){ | ||
| widgetY += 4; | ||
| widgetX = 0; | ||
| } |
There was a problem hiding this comment.
What are these arbitrary numbers doing here?
There was a problem hiding this comment.
If their are more elements than space on the page, they will warp to the next row
| @@ -1,12 +1,21 @@ | |||
| var widgetX = -7; | |||
| var widgetY = -4; | |||
There was a problem hiding this comment.
It's used to arrange the widgets in a line
| <div className='card-header p-1'> | ||
| <h4 className='m-0 d-inline'>{this.props.title}</h4> | ||
| <button className='btn btn-light float-right d-inline p-0 m-1' type='button' data-toggle='modal' data-target={'#' + this.props.id + '_modal'}><h5 className='fas fa-cog m-0'></h5></button> | ||
| <div className='card m-1 grid-stack-item' style={{display:'inline-block'}} id={this.props.id + '_card'} data-gs-no-resize={this.props.noResize} data-gs-width={this.props.width} data-gs-height={this.props.height} data-gs-y={widgetY} data-gs-x={widgetX}> |
There was a problem hiding this comment.
widgetY and widgetX should be properties that are stored in the config JSON
There was a problem hiding this comment.
Also, it looks like the noresize thing isn't working. I commented on it further down too.
There was a problem hiding this comment.
This is done automatically to lay them out in a line. I feel like user input could create user error.
| <button className='btn btn-light float-right d-inline p-0 m-1' type='button' data-toggle='modal' data-target={'#' + this.props.id + '_modal'}><h5 className='fas fa-cog m-0'></h5></button> | ||
| <div className='card m-1 grid-stack-item' style={{display:'inline-block'}} id={this.props.id + '_card'} data-gs-no-resize={this.props.noResize} data-gs-width={this.props.width} data-gs-height={this.props.height} data-gs-y={widgetY} data-gs-x={widgetX}> | ||
| <div className='grid-stack-item-content'> | ||
| <div className='card-header p-1 grid-stack-item-content ui-draggable-handle'> |
There was a problem hiding this comment.
Make a button inside the header that allows for clicking and dragging
| </button> | ||
| </div> | ||
| <div className='modal-body'> | ||
| <div className='modal-b ody'> |
There was a problem hiding this comment.
fix this. This might also fix the padding issue.
| SocketHandler.connect(PageUtils.getWebSocketPageAddress()); | ||
| ReactDOM.render( | ||
| <div> | ||
| <div className="grid-stack" data-gs-width="35"> |
There was a problem hiding this comment.
I think that the width should be varied based on the browser window size. Not sure though
| $('#reactapp')[ 0 ] | ||
| ); | ||
| $(".grid-stack").gridstack({ | ||
| width: 35, |
| "height": "3", | ||
| "id": "testVarEditor", | ||
| "kwargs": {}, | ||
| "resize": false, |
There was a problem hiding this comment.
This functionality seems to be broken because I can resize this widget.
There was a problem hiding this comment.
This works on my machine. If you get a chance can you check dev tools and make sure there is a data-gs-no-resize property?
2 participants
Implements moving widget on a grid