feat: Add support for generating background mesh from a brain mask when viewing native space bundles#2
Open
gagnonanthony wants to merge 1 commit intoteanijarv:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @teanijarv !
Thank you for developing this nice library! I have a rather specific (or maybe not) use case where I would like to use your library to generate QC screenshots of WM bundles. The thing is, the bundles are in subject-space, so overlaying them with template meshes gives poor results.
I propose adding an option to visualize the bundles with a mesh generated from a brain mask. This way, bundles can be viewed even in subject-space while having a background for a rough estimate of the location within the brain.
Here's a code snippet to test it out:
And here's an example of what it would look like:

I tried to modify as few lines as possible, feel free to ask for changes if needed. Again, great library!