Aws sdk v3

[jeggers-88]

Followed: #22 @ww-daniel-mora 😃

First of all, I really like your project to migrate dynamo! We are going to use it in production now...

This is my first contribution here and in github in general, could be that I am doing things wrong 🙏

Notes:

• generally the migration from aws-sdk v2 to v3 was straightforward
• in order to keep the changes not too big using aws-sdk v3 now, I still used the v2 syntax AWS.Dynamo() (together with import * as AWS from '@aws-sdk/client-dynamodb') and not import { DynamoDBClient } from "@aws-sdk/client-dynamodb";
  • why ? Using the v2 syntax we can still can use createTable(), putItem() on the ddb instance. Alternatively using the v3 syntax we would need to refactor to always use client.send(command). Hope that is ok for you.
• some functions are not available in v3
  • for example AWS.SharedIniFileCredentials(). Had to use fromIni instead and refactor a bit
  • same for ddb.waitFor() we now have to use waitUntilTableExists()
• for mocking aws-sdk we have to switch to aws-sdk-client-mock
• see also blog post
• unit tests on my local machine are all green, but I did not execute any e2e tests using a hosted dynamodb
  • is this needed before merging ? Should I do that ? What test cases should we cover ?
• versioning and readme:
  • I think we should increase the major version because the old migrations using the ddb instance from aws-sdk v2 potentially get errors now passing in a ddb instance from v3
  • I assume we need to write something about this in the README.md, who should do this ? I can make a proposal...
  • should we have a beta version and do some e2e testing together on that ?

Big thanks in advance for feedback and a review! And can you please trigger the actions, so that we see that the unit tests are also working in the github pipeline ?

Best regards
Johan

[jeggers-88]

I was so free to add this to .gitignore as we also ignore '.idea'

[jeggers-88]

Hi @mukund1488 , sorry ! Calling for help here. Is this repo maintained ? Can somebody look over my PR, please?