fix: disable SDK retries on all web3 steps and match error formats#498
Open
fix: disable SDK retries on all web3 steps and match error formats#498
Conversation
…formats
Set maxRetries = 0 on 15 steps missing it to prevent the SDK durability
layer from retrying and producing spurious failure errors. Update the
reconciler to detect both SDK error formats ("exceeded max retries" and
"failed after N retries") as defense in depth.
suisuss
changed the title
suisuss
changed the title
eskp
requested review from
a team,
OleksandrUA,
eskp and
joelorzet
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxRetries = 0on 15 steps that were missing it, preventing the SDK durability layer from retrying and producing spurious "exceeded max retries" / "failed after N retries" errorsisSdkRetryError()helper andFAILED_AFTER_RETRIES_MARKERconstantTest plan
pnpm check)pnpm test tests/unit/max-retries-reconciler.test.ts)