fix(sql-editor): harden result paging and simplify recent UI code#102
Merged
Conversation
Fail closed on page wrap with offset, skip wraps for non-SELECT, ignore stale page fetches after a new Run, and gate Next on pageMeta. Also tidy the recent SQL Editor helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_4f499b36-d5d6-4984-8ff5-89e2d2b864a5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail closed on page wrap with offset, skip wraps for non-SELECT, ignore stale page fetches after a new Run, and gate Next on pageMeta. Also tidy the recent SQL Editor helpers.
Note
Medium Risk
Changes core SQL execute paging semantics and result store concurrency; mistakes could break Next/Prev or show wrong rows, but behavior is covered by new tests and fail-closed rules.
Overview
SQL result paging is tightened end-to-end so Next/Prev stay trustworthy. The execute path adds
isPageableStatementso only SELECT/VALUES (viastatementVerb) get LIMIT/OFFSET wraps; UPDATE/DDL/SET run raw at offset 0, and offset > 0 on non-SELECTs errors without hitting the DB. When wrap fails at offset > 0, the API fails closed (Paging failed: …) instead of falling back to unwrapped SQL that would repeat page 0.The store bumps
pageEpochon each Run andloadResultPageignores stale responses viaisCurrentPageEpoch; paging is blocked while a run is in flight. ResultsPanel only enables prev/next frompageMeta.hasNext(nottruncatedalone) and disables controls during refresh.Smaller cleanups: shared
filterCallParametersfor schema explorer and Monaco completion,GridToolbar/bindAxisDragrefactors, and minor themecolor-mixhelper inuiStore.Reviewed by Cursor Bugbot for commit 2a099f6. Bugbot is set up for automated code reviews on this repo. Configure here.