feat(sql-editor): Data Peek polish + DB2 paging fix - #127
Merged
Conversation
DB2 treats identifiers like _fox_page as conditional-compilation directives (SQL20521N). Use fox_page for all dialect page wraps. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Makes DB2 alias issues (e.g. legacy _fox_page) visible in the UI so a stale API process is obvious after checkout. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Constrain the peek modal and grid height so wide tables scroll inside the viewport. Use high-contrast CSS vars for numeric cells and FK links (replace washed cyan on the light paper grid). Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Stack sibling drills per FK column (order / technician / lifecycle can all stay open). FK cells keep the dark number color with underline only. Fit the peek modal to the viewport with compact child panels. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Add per-panel WHERE / ORDER BY / LIMIT with safe clause checks, drag-to-resize grids, and high-contrast rust foreign-key link colors. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
By credential mode no longer lays statement results side by side; each Out grid is full width with its own height resize handle. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Drill panels (e.g. technician + order) always stack full-width instead of sitting side by side. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Give stacked FK panels a taller default height and a wider modal so sub-datagrids stay readable instead of cramped. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Keep each peek panel at a fixed height (no flex-shrink) so opening many FK drills stacks into a scrollable body instead of crushing grids. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Track pageIndex per peek panel, pass OFFSET to /sql/execute, and show Prev/Next controls on ORDER_TECHNICIAN and drill grids. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Add a grip handle on each peek panel so stacked datagrids can be reordered in the main vertical scroll. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Wire rust FK links on editor result grids to open Data Peek, hoist the peek modal to SqlEditorView, and document both Schema and Results entry points in the empty-state tip and USER_GUIDE. Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Sign SQL Editor / Data Peek sources and root NOTICE for Huy Ph authorship. Keep public PR write-ups short (no long internal plans). Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
cursor
Bot
changed the title
Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Co-authored-by: huy.phan9 <huyplb@users.noreply.github.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_e63b279b-76d6-4ae8-b107-0f2ca77e5c79) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-facing SQL Editor improvements (short list only):
_(SQL20521N).NOTICE+ SPDX headers (Huy Phan); keep LICENSE/NOTICE when redistributing.Test plan
SELECT … ORDER BYwith Rows/pageCopyright 2024–2026 Huy Phan
<huyplb@gmail.com>· Apache-2.0 · seeNOTICE