-
Notifications
You must be signed in to change notification settings - Fork 16
RF: from tff_* to trx_* => rename CLI
#98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 59.76% 59.76%
=======================================
Files 12 12
Lines 2411 2411
=======================================
Hits 1441 1441
Misses 970 970
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR renames the CLI commands from tff_* to trx_* to align with the project name and improve consistency with the C wrapper CLI, addressing issue #97. The changes also simplify some command names by removing redundant "trx" from the middle or end of command names (e.g., tff_generate_trx_from_scratch → trx_generate_from_scratch).
Changes:
- Renamed unified CLI from
tfftotrx - Renamed all standalone commands from
tff_*prefix totrx_*prefix - Simplified two command names by removing redundant "trx" substring
- Updated all tests, documentation, and examples to reflect the new naming
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated script entry points from tff* to trx* commands |
| trx/cli.py | Renamed Typer app from "tff" to "trx" and updated all standalone command names |
| trx/tests/test_cli.py | Updated test methods and script_runner calls to use new trx* command names |
| docs/source/scripts.rst | Updated documentation to reflect new CLI names and command examples |
| README.md | Updated README examples to use new trx CLI and command names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot open a new pull request to apply changes based on the comments in this thread |
arokem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except those two trk/trx cases that copilot found.
Thanks, fixed |
Small PR to fix CLI name.
fix #97