-
Notifications
You must be signed in to change notification settings - Fork 32
Use the referencing library where available
#253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| """Compatibility layer for jsonschema validation.""" | ||
|
|
||
| from typing import Any, Optional | ||
|
|
||
| import jsonschema | ||
| from jsonschema.validators import Draft4Validator | ||
|
|
||
|
|
||
| def get_validator( | ||
| schema: Any, | ||
| schema_store: Optional[dict[str, Any]] = None | ||
| ) -> Draft4Validator: | ||
| """Create a validator instance based on available jsonschema version.""" | ||
| # Validate schema is a dict | ||
| if not isinstance(schema, dict): # TODO remove once mypy/pyright is added | ||
| from fmf.utils import JsonSchemaError | ||
| raise JsonSchemaError(f'Invalid schema type: {type(schema)}. Schema must be a dictionary.') | ||
|
|
||
| schema_store = schema_store or {} | ||
|
|
||
| try: | ||
| from jsonschema import validators | ||
| from referencing import Registry, Resource | ||
| from referencing.jsonschema import DRAFT4 | ||
|
|
||
| # Modern approach with referencing | ||
| resources = [] | ||
| for uri, contents in schema_store.items(): | ||
| # Try to create resource from contents (will use $schema if present) | ||
| try: | ||
| resource = Resource.from_contents(contents) | ||
| except Exception: | ||
| # If that fails, explicitly create as Draft4 | ||
| resource = DRAFT4.create_resource(contents) | ||
| resources.append((uri, resource)) | ||
|
|
||
| registry = Registry().with_resources(resources) | ||
|
|
||
| # Create validator using Draft4 meta-schema | ||
| validator_cls = validators.validator_for(schema, default=Draft4Validator) | ||
| return validator_cls(schema=schema, registry=registry) | ||
|
|
||
| except ImportError: | ||
| # Legacy approach with RefResolver | ||
| try: | ||
| resolver = jsonschema.RefResolver.from_schema( | ||
| schema, store=schema_store) | ||
| except AttributeError as error: | ||
| from fmf.utils import JsonSchemaError | ||
| raise JsonSchemaError(f'Provided schema cannot be loaded: {error}') | ||
| return Draft4Validator(schema, resolver=resolver) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.