Skip to content

Skip known bootc failure for now#4630

Merged
happz merged 3 commits intoteemtee:mainfrom
LecrisUT:chore/flaky/bootc-avc
Mar 2, 2026
Merged

Skip known bootc failure for now#4630
happz merged 3 commits intoteemtee:mainfrom
LecrisUT:chore/flaky/bootc-avc

Conversation

@LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Mar 2, 2026

Thanks to #4248 we can actually be more granular about this now 😉.

Tracked in https://bugzilla.redhat.com/show_bug.cgi?id=2443825

@LecrisUT LecrisUT added this to planning Mar 2, 2026
@LecrisUT LecrisUT added the ci | full test Pull request is ready for the full test execution label Mar 2, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Mar 2, 2026
@LecrisUT LecrisUT added the status | blocking other work An important pull request, blocking other pull requests or issues label Mar 2, 2026
@LecrisUT LecrisUT moved this from backlog to review in planning Mar 2, 2026
@LecrisUT LecrisUT added the review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-) label Mar 2, 2026
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 2, 2026

@therazix can you check that I am using it correctly? 🙂 Also thanks for this feature

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an adjust rule to tests/provision/bootc/main.fmf to ignore a specific AVC denial. Change the version comparison from distro > fedora-42 to distro >= fedora-42 to ensure the workaround also applies to Fedora 42.

@therazix
Copy link
Contributor

therazix commented Mar 2, 2026

@therazix can you check that I am using it correctly? 🙂 Also thanks for this feature

The usage seems correct, but keep in mind that when you set ignore-pattern yourself, it will override the default ignore patterns. Currently, type=USER_AVC.*received policyload notice is the only default pattern in that list.

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 2, 2026

Currently, type=USER_AVC.*received policyload notice is the only default pattern in that list.

Oh, thank you for that info. Should I add it here regardless, or wait on the CI to see if we need it?

@therazix
Copy link
Contributor

therazix commented Mar 2, 2026

Oh, thank you for that info. Should I add it here regardless, or wait on the CI to see if we need it?

I would add it regardless.

@LecrisUT LecrisUT force-pushed the chore/flaky/bootc-avc branch from 479f667 to 8961750 Compare March 2, 2026 17:34
LecrisUT added 2 commits March 2, 2026 18:35
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT LecrisUT force-pushed the chore/flaky/bootc-avc branch from 8961750 to 3ab2158 Compare March 2, 2026 17:35
@bajertom bajertom moved this from review to merge in planning Mar 2, 2026
@happz
Copy link
Contributor

happz commented Mar 2, 2026

$ http -p b GET https://artifacts.osci.redhat.com/testing-farm/fafbd116-317c-411b-af40-fd4d1b55e7a7/work-bootc3cyhbi6_/plans/provision/bootc/execute/data/guest/default-0/tests/provision/bootc-1/checks/failures.yaml | yq '.[]'
# --- ausearch
# Finished successfully

# stdout (2 lines)
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
type=SELINUX_ERR msg=audit(03/02/26 17:51:06.823:2252) : op=security_bounded_transition seresult=denied oldcontext=system_u:system_r:install_t:s0:c192,c774 newcontext=system_u:system_r:mount_t:s0:c192,c774
type=SELINUX_ERR msg=audit(03/02/26 18:09:39.471:2953) : op=security_bounded_transition seresult=denied oldcontext=system_u:system_r:install_t:s0:c603,c905 newcontext=system_u:system_r:mount_t:s0:c603,c905
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

# stderr (6 lines)
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ export LC_ALL=C
+ LC_ALL=C
+ source /var/ARTIFACTS/work-bootc3cyhbi6_/plans/provision/bootc/execute/data/guest/default-0/tests/provision/bootc-1/checks/avc-mark.txt
++ export 'AVC_SINCE=03/02/26 17:48:41'
++ AVC_SINCE='03/02/26 17:48:41'
+ ausearch -i --input-logs -m AVC,USER_AVC,SELINUX_ERR -ts 03/02/26 17:48:41
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

What a nice, brand new AVC failure our patterns do not waive because we never seen it before :/

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 2, 2026

Oops, it was in the original avc.txt but I did not notice the difference in SELINUX_ERR. Reading comprehension and all that

Signed-off-by: Cristian Le <git@lecris.dev>
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 2, 2026

$ http -p b GET https://artifacts.osci.redhat.com/testing-farm/fafbd116-317c-411b-af40-fd4d1b55e7a7/work-bootc3cyhbi6_/plans/provision/bootc/execute/data/guest/default-0/tests/provision/bootc-1/checks/failures.yaml | yq '.[]'
# --- ausearch
# Finished successfully

# stdout (2 lines)
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
type=SELINUX_ERR msg=audit(03/02/26 17:51:06.823:2252) : op=security_bounded_transition seresult=denied oldcontext=system_u:system_r:install_t:s0:c192,c774 newcontext=system_u:system_r:mount_t:s0:c192,c774
type=SELINUX_ERR msg=audit(03/02/26 18:09:39.471:2953) : op=security_bounded_transition seresult=denied oldcontext=system_u:system_r:install_t:s0:c603,c905 newcontext=system_u:system_r:mount_t:s0:c603,c905
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

# stderr (6 lines)
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ export LC_ALL=C
+ LC_ALL=C
+ source /var/ARTIFACTS/work-bootc3cyhbi6_/plans/provision/bootc/execute/data/guest/default-0/tests/provision/bootc-1/checks/avc-mark.txt
++ export 'AVC_SINCE=03/02/26 17:48:41'
++ AVC_SINCE='03/02/26 17:48:41'
+ ausearch -i --input-logs -m AVC,USER_AVC,SELINUX_ERR -ts 03/02/26 17:48:41
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

What a nice, brand new AVC failure our patterns do not waive because we never seen it before :/

Hmm, it does smell like a genuine issue on our side. Maybe it's an issue with the new bootc mounting during the prepare install step and such?

@happz
Copy link
Contributor

happz commented Mar 2, 2026

Oops, it was in the original avc.txt but I did not notice the difference in SELINUX_ERR. Reading comprehension and all that

Ah, I thought it's a new one, present just to kick sand in our tea. Never noticed in the previous runs.

@happz
Copy link
Contributor

happz commented Mar 2, 2026

$ http -p b GET https://artifacts.osci.redhat.com/testing-farm/fafbd116-317c-411b-af40-fd4d1b55e7a7/work-bootc3cyhbi6_/plans/provision/bootc/execute/data/guest/default-0/tests/provision/bootc-1/checks/failures.yaml | yq '.[]'
# --- ausearch
# Finished successfully

# stdout (2 lines)
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
type=SELINUX_ERR msg=audit(03/02/26 17:51:06.823:2252) : op=security_bounded_transition seresult=denied oldcontext=system_u:system_r:install_t:s0:c192,c774 newcontext=system_u:system_r:mount_t:s0:c192,c774
type=SELINUX_ERR msg=audit(03/02/26 18:09:39.471:2953) : op=security_bounded_transition seresult=denied oldcontext=system_u:system_r:install_t:s0:c603,c905 newcontext=system_u:system_r:mount_t:s0:c603,c905
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

# stderr (6 lines)
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ export LC_ALL=C
+ LC_ALL=C
+ source /var/ARTIFACTS/work-bootc3cyhbi6_/plans/provision/bootc/execute/data/guest/default-0/tests/provision/bootc-1/checks/avc-mark.txt
++ export 'AVC_SINCE=03/02/26 17:48:41'
++ AVC_SINCE='03/02/26 17:48:41'
+ ausearch -i --input-logs -m AVC,USER_AVC,SELINUX_ERR -ts 03/02/26 17:48:41
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

What a nice, brand new AVC failure our patterns do not waive because we never seen it before :/

Hmm, it does smell like a genuine issue on our side. Maybe it's an issue with the new bootc mounting during the prepare install step and such?

Could be. A waiver, another tracking issue against selinux policy, and investigate more as we go?

@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 2, 2026

/packit retest-failed

LecrisUT added a commit to LecrisUT/tmt that referenced this pull request Mar 2, 2026
@LecrisUT
Copy link
Contributor Author

LecrisUT commented Mar 2, 2026

Could be. A waiver, another tracking issue against selinux policy, and investigate more as we go?

Yep, added it to the ignore pattern and opened #4634 as a perpetual check for every next sprint.

@happz happz merged commit 2d24d83 into teemtee:main Mar 2, 2026
31 checks passed
@github-project-automation github-project-automation bot moved this from merge to done in planning Mar 2, 2026
@psss psss added this to the 1.69 milestone Mar 3, 2026
LecrisUT added a commit to LecrisUT/tmt that referenced this pull request Mar 3, 2026
@LecrisUT LecrisUT deleted the chore/flaky/bootc-avc branch March 3, 2026 15:21
LecrisUT added a commit to LecrisUT/tmt that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution review | trivial Very easy for review, even for beginners, so don't be afraid to have a look! :-) status | blocking other work An important pull request, blocking other pull requests or issues

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

5 participants