Skip to content

Add virtualization.confidential hardware requirement#4638

Open
thrix wants to merge 6 commits intomainfrom
add-virtualization-confidential
Open

Add virtualization.confidential hardware requirement#4638
thrix wants to merge 6 commits intomainfrom
add-virtualization-confidential

Conversation

@thrix
Copy link
Contributor

@thrix thrix commented Mar 3, 2026

Summary

Add a new boolean hardware requirement virtualization.confidential for specifying that a guest should be provisioned as a confidential VM with a hardware-based Trusted Execution Environment (TEE).

Confidential VMs use technologies like AMD SEV-SNP, Intel TDX, or ARM CCA to protect data while in use by encrypting VM memory from the hypervisor. All major cloud providers (Azure, GCP, AWS) support this.

Changes

  • Spec: Added confidential: true|false to spec/hardware/virtualization.fmf
  • Parser: Added 'confidential' to the flag constraints in _parse_virtualization()
  • Schema: Added confidential boolean property to the virtualization block in hardware.yaml
  • Tests: Updated FULL_HARDWARE_REQUIREMENTS and expected output in test_hardware.py

No provisioner transformer is included initially, consistent with how virtualization.is-supported is handled.

Closes #4637 TFT-4391

Assisted-by Claude Code

Pull Request Checklist

  • implement the feature
  • extend the test coverage
  • update the specification
  • modify the json schema
  • mention the version
  • include a release note

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the virtualization.confidential hardware requirement. The implementation correctly updates the specification, schema, parser, and tests. The changes are consistent and self-contained. No issues were found.

@psss psss changed the title Add virtualization.confidential hardware requirement Add virtualization.confidential hardware requirement Mar 4, 2026
@thrix
Copy link
Contributor Author

thrix commented Mar 10, 2026

@tcornell-bus kindly asking for re-review

@happz
Copy link
Contributor

happz commented Mar 10, 2026

@thrix please, set the "Size" of this PR.

Copy link
Collaborator

@tcornell-bus tcornell-bus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thrix thrix moved this from implement to review in planning Mar 10, 2026
@thrix
Copy link
Contributor Author

thrix commented Mar 10, 2026

@thrix please, set the "Size" of this PR.

@happz done, thx

@thrix thrix force-pushed the add-virtualization-confidential branch 2 times, most recently from 19bae02 to 49d3ad5 Compare March 10, 2026 22:09
@bajertom bajertom force-pushed the add-virtualization-confidential branch from 49d3ad5 to 14156a2 Compare March 11, 2026 08:47
@bajertom bajertom added the ci | full test Pull request is ready for the full test execution label Mar 11, 2026
@bajertom
Copy link
Contributor

/packit test

thrix and others added 4 commits March 11, 2026 23:37
Add a new boolean hardware requirement for specifying that a guest
should be provisioned as a confidential VM with a hardware-based
Trusted Execution Environment (TEE) such as AMD SEV-SNP, Intel TDX,
or ARM CCA.

Closes #4637

Assisted-by Claude Code
- Clarify implemented-by notes for both artemis and mrack
- Shorten release note and add external link

Assisted-by Claude Code
Co-authored-by: tcornell-bus <tcornell@redhat.com>
Add a note to the versionadded directive and a footnote to the
hardware support table explaining that virtualization.confidential
is not yet supported by any provisioner plugin.

Assisted-by Claude Code
@thrix thrix force-pushed the add-virtualization-confidential branch from 14156a2 to bd30d2f Compare March 11, 2026 22:37
Copy link
Contributor

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, just the versionadded confusion.

Co-authored-by: Miroslav Vadkerti <mvadkert@redhat.com>
@thrix thrix requested a review from psss March 12, 2026 09:51
@psss psss added the area | hardware Implementation of hardware requirements label Mar 12, 2026
@thrix thrix self-assigned this Mar 12, 2026
@LecrisUT LecrisUT moved this from review to merge in planning Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution

Projects

Status: merge

Development

Successfully merging this pull request may close these issues.

Add virtualization.confidential hardware requirement

6 participants