Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
added
status | blocking other work
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully exposes typing.override through the tmt._compat.typing module. This change aligns with the existing compatibility patterns in the codebase, ensuring that the override decorator is available across different Python versions by conditionally importing it from typing or typing_extensions.
For a "Large language model" this thing does not have a grasp of either language or coding. How would you unsuccessfully do that 🙄. Thoughts on making it shut up if it doesn't have anything productive to contribute? Among this and graphite, I much prefer the latter because it's not like 🤓☝️ every time |
thrix
left a comment
thrix
left a comment
There was a problem hiding this comment.
LGTM. Correct version gate (>= 3.12), follows the established pattern for the other compat imports (Self, TypeGuard, etc.), ruff ban added. No issues found.
Generated-by: Claude Code
5 participants
Separated from #4654. See there for more context of why it is needed