Delay the creation of the LogfileHandler#4677
Draft
LecrisUT wants to merge 16 commits intoteemtee:mainfrom
Draft
Delay the creation of the LogfileHandler#4677LecrisUT wants to merge 16 commits intoteemtee:mainfrom
LecrisUT wants to merge 16 commits intoteemtee:mainfrom
Conversation
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Signed-off-by: Cristian Le <git@lecris.dev>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a warnings.yaml log and refactors workdir loading. A change to LogfileHandler breaks stacktrace logging to files. The default for the new with_stacktrace parameter should be True to fix this for existing code. The handler for warnings.yaml must then explicitly set this to False.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for some refactoring of the workdir initialization logic, see the comment
tmt/tmt/utils/__init__.py
Lines 2463 to 2470 in eb8ed04
The purpose of this is to be able to:
Common._workdiris defined and make it available much earlier. Refactoring where/when to do the creation of the workdir would follow afterwardsadd_logfile_handleris executed and do not add it unless we are in atmt runloopPull Request Checklist
Depends-on: #4642