Skip to content

Fix issues with check-wheel-contents#4682

Merged
LecrisUT merged 1 commit intoteemtee:mainfrom
LecrisUT:fix/check-wheel
Mar 13, 2026
Merged

Fix issues with check-wheel-contents#4682
LecrisUT merged 1 commit intoteemtee:mainfrom
LecrisUT:fix/check-wheel

Conversation

@LecrisUT
Copy link
Contributor

Reported when the recent release workflow was run:

/tmp/baipp/dist/tmt-1.69.0-py3-none-any.whl: W002: Wheel contains duplicate files:
  tmt/steps/report/junit/templates/default.xml.j2
  tmt/steps/report/junit/templates/polarion.xml.j2

Pull Request Checklist

  • implement the feature

@LecrisUT LecrisUT added packaging Changes related to the rpm packaging status | blocking other work An important pull request, blocking other pull requests or issues labels Mar 12, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Mar 12, 2026
@LecrisUT LecrisUT moved this from backlog to review in planning Mar 12, 2026
@LecrisUT LecrisUT mentioned this pull request Mar 12, 2026
4 tasks
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This change disables a check for duplicate files in the wheel. Address the underlying file duplication instead of suppressing the warning globally. This improves long-term maintainability.

Signed-off-by: Cristian Le <git@lecris.dev>
Copy link
Contributor

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct. The two template files (default.xml.j2 and polarion.xml.j2) are intentionally separate Jinja2 flavors that happen to have the same content currently — suppressing W002 globally is the right approach since symlinks don't survive wheel packaging and these templates may diverge in the future.

Generated-by: Claude Code

@LecrisUT LecrisUT moved this from review to merge in planning Mar 13, 2026
@LecrisUT
Copy link
Contributor Author

Does not affect tmt execution. Merging without waiting for CI, relevant check is in #4681 anyway

@LecrisUT LecrisUT merged commit be8a734 into teemtee:main Mar 13, 2026
18 checks passed
@github-project-automation github-project-automation bot moved this from merge to done in planning Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packaging Changes related to the rpm packaging status | blocking other work An important pull request, blocking other pull requests or issues

Projects

Status: done

Development

Successfully merging this pull request may close these issues.

3 participants