copr.repository provider creates a Repository object#4695
Open
AthreyVinay wants to merge 1 commit intomainfrom
Open
copr.repository provider creates a Repository object#4695AthreyVinay wants to merge 1 commit intomainfrom
copr.repository provider creates a Repository object#4695AthreyVinay wants to merge 1 commit intomainfrom
Conversation
AthreyVinay
added
step | prepare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the copr.repository provider to create a Repository object. It introduces a CoprArtifactProvider base class for shared Copr logic. My feedback focuses on improving exception handling and attribute initialization for better robustness.
LecrisUT
reviewed
Mar 13, 2026
Comment on lines
-289
to
+312
| # Parse the copr repo name | ||
| matched = COPR_REPO_PATTERN.match(copr) | ||
| if not matched: | ||
| raise PrepareError(f"Invalid copr repository '{copr}'.") | ||
| group, name, project = matched.groups() | ||
| group = 'group_' if group else '' | ||
| # Prepare the repo file url | ||
| parts = [COPR_URL] + (['g'] if group else []) | ||
| parts += [name, project, 'repo', 'epel-6'] | ||
| parts += [f"{group}{name}-{project}-epel-6.repo"] | ||
| url = '/'.join(parts) | ||
| url = build_copr_repo_url(copr, 'epel-6') |
Contributor
There was a problem hiding this comment.
Do we still support this? Copr repos in https://copr.fedorainfracloud.org/coprs do not have epel-6 chroot anymore. @psss @happz @thrix? Could probably still be accessed on internal copr, but at that point the hard-coded url would still get in the way.
Contributor
Author
There was a problem hiding this comment.
Nice one - havent seen epel-6 there.
AthreyVinay
added
the
ci | full test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4692