Add pending task tracking to Guest for workload monitoring#4696
Add pending task tracking to Guest for workload monitoring#4696skycastlelily wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces pending task tracking on Guest objects, which is a valuable addition for workload monitoring and resource management. The implementation is thread-safe and handles task increments and decrements correctly, including in abort scenarios.
I've identified two areas for improvement in tmt/steps/execute/__init__.py to enhance code clarity and conciseness. One is simplifying a loop for finding a discover phase, and the other is removing a redundant condition check.
| discover_phase = None | ||
| for discover in self.plan.discover.phases(classes=(DiscoverPlugin,)): | ||
| if discover.name == discover_phase_name and discover.enabled_by_when: | ||
| discover_phase = discover | ||
| break |
There was a problem hiding this comment.
Simplify finding the discover phase. Use next() with a generator expression for conciseness and improved readability.
discover_phase = next((
discover for discover in self.plan.discover.phases(classes=(DiscoverPlugin,))
if discover.name == discover_phase_name and discover.enabled_by_when),
None)|
|
||
| # Check if this test runs on any of the current guests | ||
| for guest in guests: | ||
| if test.enabled_on_guest is None or test.enabled_on_guest(guest): |
There was a problem hiding this comment.
Remove the redundant test.enabled_on_guest is None check. The enabled_on_guest attribute is a method and can never be None, so this check is always false.
if test.enabled_on_guest(guest):
Implements task counters on Guest objects to track pending test executions during the execute phase. This enables: - Resource management and cleanup decisions based on guest workload - Progress monitoring across distributed test execution - Proper state handling during abort scenarios - Foundation for future load balancing enhancements
skycastlelily
force-pushed
the
task-tracking
branch
from
eb5d71b to
ccb14e1
Compare
1 participant
Implements task counters on Guest objects to track pending test executions during the execute phase. This enables:
Pull Request Checklist