Skip to content

Task #0000 chore: Audit logs with kafka#1

Open
kkbiswal wants to merge 10 commits into
tekdi:product-release1.0.0from
kkbiswal:auditlog
Open

Task #0000 chore: Audit logs with kafka#1
kkbiswal wants to merge 10 commits into
tekdi:product-release1.0.0from
kkbiswal:auditlog

Conversation

@kkbiswal
Copy link
Copy Markdown
Collaborator

@kkbiswal kkbiswal commented May 4, 2026

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the @your-org/audit-logger SDK, a comprehensive audit logging solution for NestJS and Node.js services featuring PII processing, event filtering, and a multi-transport dispatch chain (Kafka, API, and local buffering). The review feedback identifies several high-priority architectural and performance issues: the use of module-level globals for Kafka connections prevents independent logger configurations, synchronous file system operations in the local buffer risk blocking the event loop, and the file-based buffering logic suffers from O(N^2) complexity. Additionally, suggestions were made to use structuredClone for more efficient object copying and to optimize the ring buffer implementation to avoid O(N) shift operations.

Comment thread src/transports/kafka-transport.ts Outdated
Comment thread src/buffer/local-buffer.ts Outdated
Comment thread src/buffer/local-buffer.ts Outdated
Comment thread src/pii/pii-processor.ts Outdated
Comment thread src/buffer/local-buffer.ts Outdated
Comment thread src/transports/kafka-transport.ts Outdated
@kkbiswal kkbiswal changed the base branch from main to product-release1.0.0 May 25, 2026 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant