Task #0000 chore: Audit logs with kafka#1
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the @your-org/audit-logger SDK, a comprehensive audit logging solution for NestJS and Node.js services featuring PII processing, event filtering, and a multi-transport dispatch chain (Kafka, API, and local buffering). The review feedback identifies several high-priority architectural and performance issues: the use of module-level globals for Kafka connections prevents independent logger configurations, synchronous file system operations in the local buffer risk blocking the event loop, and the file-based buffering logic suffers from O(N^2) complexity. Additionally, suggestions were made to use structuredClone for more efficient object copying and to optimize the ring buffer implementation to avoid O(N) shift operations.
No description provided.