fix: use correct FIREBASE_PROJECT_ID for Firebase initialization#54
fix: use correct FIREBASE_PROJECT_ID for Firebase initialization#54hitakshiA wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughA bug fix correcting the Firebase service account configuration to use the proper environment variable Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



The serviceAccount object in the PushAdapter constructor was using FIREBASE_PRIVATE_KEY for the projectId field instead of FIREBASE_PROJECT_ID. This causes Firebase Admin SDK initialization to fail, breaking all push notifications.
The getAccessToken() method on line 134 already uses the correct FIREBASE_PROJECT_ID — this was a copy-paste error in the constructor.
What changed
No new dependencies. No behavior change for other notification channels.