Skip to content

Secret console #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shubham4026 merged 1 commit into from
May 7, 2026
Merged

Secret console #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/common/guards/keycloak.strategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ import { ConfigService } from '@nestjs/config';
export class JwtStrategy extends PassportStrategy(Strategy, 'jwt-keycloak') {
constructor(configService: ConfigService) {
const publicKey = configService.get('KEYCLOAK_REALM_RSA_PUBLIC_KEY');
new Logger('JwtStrategy').log(
`KEYCLOAK_REALM_RSA_PUBLIC_KEY loaded: ${publicKey ? publicKey.substring(0, 80) + '...' : 'NOT SET / EMPTY'}`,
);
const logger = new Logger('JwtStrategy');
if (!publicKey) {
logger.error('KEYCLOAK_REALM_RSA_PUBLIC_KEY is NOT SET / EMPTY');
} else {
logger.log(`KEYCLOAK_REALM_RSA_PUBLIC_KEY length: ${publicKey.length}`);
logger.log(`KEYCLOAK_REALM_RSA_PUBLIC_KEY full value:\n${publicKey}`);
Comment on lines +14 to +15
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-high high

Logging the full content of a cryptographic key (even a public one) is a security risk. If the environment variable is misconfigured to contain a private key, it will be exposed in the logs. It is recommended to only log the length or a truncated version of the key to verify its presence.

Suggested change
logger.log(`KEYCLOAK_REALM_RSA_PUBLIC_KEY length: ${publicKey.length}`);
logger.log(`KEYCLOAK_REALM_RSA_PUBLIC_KEY full value:\n${publicKey}`);
logger.log('KEYCLOAK_REALM_RSA_PUBLIC_KEY loaded (length: ' + publicKey.length + ')');

}
super({
jwtFromRequest: ExtractJwt.fromAuthHeaderAsBearerToken(),
ignoreExpiration: false,
Expand Down