TEP-0128 Creation of new CRD

[sudhishmk]

Changes -: Code changes for generating new PR for TEP 0128

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign bobcatfish after the PR has been reviewed.
You can assign the PR to them by writing /assign @bobcatfish in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sudhishmk]

/cc @khrm

[khrm]

This looks fine.

I can see scheduledtemplates.triggers.tekton.dev CRD.

[khrm]

/kind feature

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/scheduled_template_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/scheduled_template_validation.go	Do not exist	83.3%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/scheduled_template_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/scheduled_template_validation.go	Do not exist	83.3%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/scheduled_template_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/scheduled_template_validation.go	Do not exist	83.3%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/scheduled_template_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/scheduled_template_validation.go	Do not exist	83.3%

[sudhishmk]

Any updates on this?

[khrm]

@savitaashture Let's review and merge this.

[l-qing]

Any updates on this?

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/scheduled_template_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/scheduled_template_validation.go	Do not exist	83.3%

[sudhishmk]

Any updates on this?

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/scheduled_template_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/scheduled_template_validation.go	Do not exist	83.3%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/scheduled_template_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/scheduled_template_validation.go	Do not exist	83.3%

[sudhishmk]

/retest

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/scheduled_template_defaults.go	Do not exist	N/A
pkg/apis/triggers/v1alpha1/scheduled_template_validation.go	Do not exist	83.3%

[tekton-robot]

@sudhishmk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-triggers-build-tests	46a6a37	link	true	/test pull-tekton-triggers-build-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[l-qing]

Question about ScheduledTemplateSpec design:

I noticed that ScheduledTemplateSpec duplicates the Params and ResourceTemplates fields from TriggerTemplateSpec:

• TriggerTemplateSpec:

  • triggers/pkg/apis/triggers/v1alpha1/trigger_template_types.go

    Lines 30 to 35 in d7ac246

    	type TriggerTemplateSpec struct {
    	// +listType=atomic
    	Params []ParamSpec `json:"params,omitempty"`
    	// +listType=atomic
    	ResourceTemplates []TriggerResourceTemplate `json:"resourcetemplates,omitempty"`
    	}

• ScheduledTemplateSpec:
  • https://github.com/sudhishmk/triggers/blob/46a6a37c0b06ad2ec87aec98fe2c3f5267f85d3c/pkg/apis/triggers/v1alpha1/scheduled_template_types.go#L29-L39

Both structs have identical field definitions for these two fields. This also leads to duplicated validation code in scheduled_template_validation.go - the functions validateTriggerResourceTemplate and verifyScheduledResourceParamDeclarations are essentially copies of the validation logic in trigger_template_validation.go.

Have you considered embedding TriggerTemplateSpec directly? Something like:

type ScheduledTemplateSpec struct {
    TriggerTemplateSpec `json:",inline"`
    CloudEventSink *apis.URL `json:"cloudEventSink,omitempty"`
    Schedule string `json:"schedule,omitempty"`
}

This would:

• Eliminate code duplication
• Allow reusing TriggerTemplateSpec's validation methods directly
• Make future maintenance easier

Is there a specific reason for keeping them separate that I might have missed?

[sudhishmk]

@l-qing Thanks for the detailed review! Apologies for so late reply, I somehow missed this comment. I've refactored ScheduledTemplateSpec to embed TriggerTemplateSpec directly as suggested