fix(ResourcesLib): prevent value calculation from overwriting stored resource data#1
Open
DevAryanPro wants to merge 1 commit intotelebothost:mainfrom
Open
fix(ResourcesLib): prevent value calculation from overwriting stored resource data#1DevAryanPro wants to merge 1 commit intotelebothost:mainfrom
DevAryanPro wants to merge 1 commit intotelebothost:mainfrom
Conversation
…resource data Fixed critical bug in ResourcesLib where value() method with enabled growth was overwriting actual stored resource values with calculated growth values. Changes: - Modified value() method to use _calcValue() directly instead of getValue() - This prevents the internal _set() call that was corrupting stored data - Growth calculations now return computed values without modifying base storage Impact: - Resolves issue where resource values would reset to 0 after growth calculations - Ensures add() operations work correctly with growth features enabled - Maintains accurate base value storage while providing correct calculated values Test results before fix: - Old Value: 600, Added: 100, New Value: 0 ❌ - After fix: Values now persist correctly through operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed critical bug in ResourcesLib where value() method with enabled growth
was overwriting actual stored resource values with calculated growth values.
Changes:
Impact:
Test results before fix: