Skip to content

enable class overriding#7

Open
alvinsj wants to merge 2 commits intomasterfrom
enable-class-option
Open

enable class overriding#7
alvinsj wants to merge 2 commits intomasterfrom
enable-class-option

Conversation

@alvinsj
Copy link

@alvinsj alvinsj commented Jul 3, 2018

No description provided.

@alvinsj alvinsj requested a review from olejrosendahl July 3, 2018 03:23
Copy link
Member

@olejrosendahl olejrosendahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for the new option.

@alvinsj
Copy link
Author

alvinsj commented Jul 3, 2018

@olejrosendahl added test

Copy link
Member

@olejrosendahl olejrosendahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants