Open
Conversation
obstmi
reviewed
Feb 9, 2026
Contributor
obstmi
left a comment
obstmi
left a comment
There was a problem hiding this comment.
Hi Ricardo,
good work! 👍
In addition to my code comments:
- please add an example to the html-pages in order to test it (at least for the date picker, we have an HTML page)
- please add the new props to the Storybook documentation
| border-color: var(--border-color-disabled); | ||
| background-color: var(--background-color-disabled); | ||
| } | ||
| .textarea__label--visually-hidden { |
Contributor
There was a problem hiding this comment.
If you use the getCssClassMap()-method as I proposed in my comment in textarea.tsx, then you should use a descendant selector here.
For an example see:
| max-width: none; | ||
| } | ||
| } | ||
| .date-picker__label--visually-hidden { |
Contributor
There was a problem hiding this comment.
Similar to my comment in textarea.cssyou should use a descendant selector (if you follow my proposal).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "hide-label-visually" prop to "scale-date-picker" and "scale-textarea".
The label is visually hidden while remaining accessible to screen readers, aligning these components with existing Scale APIs and improving accessibility.