Skip to content

Support be-js connected code in funtests #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjpalmer merged 13 commits into from
Aug 5, 2026
Merged

Support be-js connected code in funtests #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1b3117e
Simplify internal js and exports
tjpalmer Jul 25, 2026
90f64a2
Pass tests on full internal
tjpalmer Jul 27, 2026
1a3ef4c
Pass test test and build test
tjpalmer Jul 28, 2026
ce4651f
Clean more unused
tjpalmer Jul 28, 2026
9642fd3
Connect js except ugly type names
tjpalmer Jul 28, 2026
4a3bf4c
Pass tests
tjpalmer Jul 28, 2026
34cefd4
Fix lint
tjpalmer Jul 28, 2026
0fa29fb
Fix translator test
tjpalmer Jul 28, 2026
60a57b8
Use single prod mod for doc
tjpalmer Jul 29, 2026
68c782e
Fix repl and layout tests
tjpalmer Jul 29, 2026
d338a5d
Sort repl translations
tjpalmer Jul 29, 2026
3fc4f0a
Update test matrix
tjpalmer Jul 29, 2026
1aaec20
Merge branch 'main' into connected-js
tjpalmer Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
396 changes: 38 additions & 358 deletions be-js/src/commonMain/kotlin/lang/temper/be/js/JsBackend.kt
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 6 additions & 1 deletion be-js/src/commonMain/kotlin/lang/temper/be/js/JsNames.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,19 @@ internal class JsNames {
}
}

fun jsNameNotThis(name: ResolvedName): JsIdentifierName {
fun jsNameNotThis(name: ResolvedName, cachePretty: Boolean = false): JsIdentifierName {
if (name in monitoredCalls) {
monitoredCalls[name] = monitoredCalls[name]!! + 1
}
return when (name) {
is ExportedName if name.comesFrom(origin) -> {
JsIdentifierName.escaped(name.baseName.nameText)
}
else if cachePretty -> {
JsIdentifierName.escaped(name.prefix()).also {
tmpLNameToJsName[name] = it
}
}

@tjpalmer tjpalmer Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this for designing and remembering pretty type names, even for non-exported types, so connected code can reference them.

We'll want the same for unexported functions. I think we should change our naming so that all names go unsuffixed (but possibly _prefixed in some backends) whenever possible. I'm unsure how that relates to our general name selection strategy, but I think we really should do this not just for connected code but also to scare away fewer potential Temper users.

in localAliases -> localAliases.getValue(name)
in availableAliases -> {
val localName = unusedName(toSafePattern(name))
Expand Down
378 changes: 282 additions & 96 deletions be-js/src/commonMain/kotlin/lang/temper/be/js/JsTranslator.kt
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions be-js/src/commonTest/kotlin/lang/temper/be/js/DocJsTranslatorTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ class DocJsTranslatorTest {

@Test
fun stringConcat() = assertGeneratedDocs(
"""
$$"""
|export let bar: String;
|;;;
|"foo ${'$'}{ bar }"
|"foo ${bar}"
""".trimMargin(),
want = """
want = $$"""
|// #region __BOILERPLATE__ {{{
|/** @type {string} */
|export let bar;
|// #endregion }}}
|`foo ${'$'}{ bar }`;
|`foo ${ bar }`;
""".trimMargin(),

@tjpalmer tjpalmer Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got into this file when it was failing before exempting doc genre from internal modules. But I kept these cleanups even after repairing doc genre behavior.

)

Expand Down
Loading
Loading