add time-skipping config in WorkflowExecutionStartedEventAttributes#758
Merged
feiyang3cat merged 2 commits intomasterfrom Apr 14, 2026
Merged
add time-skipping config in WorkflowExecutionStartedEventAttributes#758feiyang3cat merged 2 commits intomasterfrom
feiyang3cat merged 2 commits intomasterfrom
Conversation
feiyang3cat
force-pushed
the
api-time-skipping-patch-1
branch
5 times, most recently
from
66cea2a to
92d6729
Compare
5 tasks
prathyushpv
approved these changes
Apr 13, 2026
prathyushpv
reviewed
Apr 13, 2026
| // parent/previous execution. | ||
| // | ||
| // The configuration may be updated after start via UpdateWorkflowExecutionOptions, which | ||
| // will be reflected in a WorkflowExecutionOptionsUpdatedEventAttributes event. |
Contributor
There was a problem hiding this comment.
Nit: Event name to WorkflowExecutionOptionsUpdated instead of WorkflowExecutionOptionsUpdatedEventAttributes.
Why don't we add TimeSkippingConfig to WorkflowExecutionOptionsUpdatedEventAttributes in this PR itself? Are you planning another PR for that?
Contributor
Author
There was a problem hiding this comment.
"Why don't we add TimeSkippingConfig to WorkflowExecutionOptionsUpdatedEventAttributes in this PR itself? Are you planning another PR for that?" -> because this WorkflowExecutionOptionsUpdatedEventAttributes already have this TimeSkippingConfig
feiyang3cat
force-pushed
the
api-time-skipping-patch-1
branch
from
92d6729 to
d9966b1
Compare
Sushisource
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
add time-skipping config (optional field) in WorkflowExecutionStartedEventAttributes
Why?
there won't be a way to show it to users and support workflow rebuilt