Skip to content

fix: use pnpm when installing from source with a frozen lockfile #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
THardy98 merged 7 commits into from
Mar 24, 2026
+10 −8
Merged

fix: use pnpm when installing from source with a frozen lockfile #713

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7e461f2
fix: use `pnpm` when installing from source with a frozen lockfile (u…
THardy98 Dec 18, 2025
686b464
pnpm not installed, use npx (avoid installation)
THardy98 Dec 18, 2025
61b54c7
use corepack instead of npx
THardy98 Dec 18, 2025
7ca419c
add proto dep (now necessary because pnpm uses strict dep isolation, …
THardy98 Dec 18, 2025
75c434b
Merge branch 'main' into ts-build-pnpm
THardy98 Mar 23, 2026
dc42e9d
pnpm override the protobuf dep (from npm override)
THardy98 Mar 24, 2026
db7f112
Merge branch 'main' into ts-build-pnpm
THardy98 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions sdkbuild/typescript.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,15 @@ func BuildTypeScriptProgram(ctx context.Context, options BuildTypeScriptProgramO
// Have to build the local repo
if st, err := os.Stat(filepath.Join(options.Version, "node_modules")); err != nil || !st.IsDir() {
// Only install dependencies, avoid triggerring any post install build scripts
cmd := exec.CommandContext(ctx, "npm", "ci", "--ignore-scripts")
cmd := exec.CommandContext(ctx, "corepack", "pnpm", "install", "--frozen-lockfile", "--ignore-scripts")
cmd.Dir = options.Version
cmd.Stdin, cmd.Stdout, cmd.Stderr = os.Stdin, os.Stdout, os.Stderr
if err := cmd.Run(); err != nil {
return nil, fmt.Errorf("failed installing SDK deps: %w", err)
}

// Build the SDK, ignore the unused `create` package as a mostly insignificant micro optimisation.
cmd = exec.CommandContext(ctx, "npm", "run", "build", "--", "--ignore", "@temporalio/create")
cmd = exec.CommandContext(ctx, "corepack", "pnpm", "run", "build", "--", "--ignore", "@temporalio/create")
cmd.Dir = options.Version
cmd.Stdin, cmd.Stdout, cmd.Stderr = os.Stdin, os.Stdout, os.Stderr
if err := cmd.Run(); err != nil {
Expand All @@ -110,15 +110,15 @@ func BuildTypeScriptProgram(ctx context.Context, options BuildTypeScriptProgramO
if err != nil {
return nil, fmt.Errorf("cannot get absolute path from version path: %w", err)
}
pkgs := []string{"activity", "client", "common", "plugin", "proto", "worker", "workflow"}
pkgs := []string{"activity", "client", "common", "plugin", "worker", "workflow"}
for _, pkg := range pkgs {
pkgPath := "file:" + filepath.Join(localPath, "packages", pkg)
packageJSONDepStr += fmt.Sprintf(`"@temporalio/%v": %q,`, pkg, pkgPath)
packageJSONDepStr += "\n "
}
} else {
version := strings.TrimPrefix(options.Version, "v")
pkgs := []string{"activity", "client", "common", "plugin", "worker", "workflow"}
pkgs := []string{"activity", "client", "common", "proto", "plugin", "worker", "workflow"}
for _, pkg := range pkgs {
packageJSONDepStr += fmt.Sprintf(` "@temporalio/%v": %q,`, pkg, version) + "\n"
}
Expand Down Expand Up @@ -149,8 +149,10 @@ func BuildTypeScriptProgram(ctx context.Context, options BuildTypeScriptProgramO
"tsconfig-paths": "^3.12.0",
"typescript": "^5.9.3"
},
"overrides": {
"protobufjs": "7.5.1"
"pnpm": {
"overrides": {
"protobufjs": "7.5.1"
}
}
}`
if err := os.WriteFile(filepath.Join(dir, "package.json"), []byte(packageJSON), 0644); err != nil {
Expand Down Expand Up @@ -216,7 +218,7 @@ func BuildTypeScriptProgram(ctx context.Context, options BuildTypeScriptProgramO
}

// Install
cmd := exec.CommandContext(ctx, "npm", "install")
cmd := exec.CommandContext(ctx, "corepack", "pnpm", "install")
cmd.Dir = dir
cmd.Stdin, cmd.Stdout, cmd.Stderr = os.Stdin, os.Stdout, os.Stderr
if options.ApplyToCommand != nil {
Expand All @@ -229,7 +231,7 @@ func BuildTypeScriptProgram(ctx context.Context, options BuildTypeScriptProgramO
}

// Compile
cmd = exec.CommandContext(ctx, "npm", "run", "build")
cmd = exec.CommandContext(ctx, "corepack", "pnpm", "run", "build")
cmd.Dir = dir
cmd.Stdin, cmd.Stdout, cmd.Stderr = os.Stdin, os.Stdout, os.Stderr
if options.ApplyToCommand != nil {
Expand Down
Loading