Resolve latest SDK versions from package registries#768
Merged
Conversation
THardy98
force-pushed
the
feature/pull-latest-package-manager
branch
from
9330c86 to
884269c
Compare
Remove version constraints from manifest files and delete lock files so local builds default to the latest SDK version. CI is unaffected as it already discovers and passes the latest version via the GitHub API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove redundant rubocop disable directive in harness/ruby/runner.rb - Suppress eslint import/no-named-as-default for ms import in TS feature Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Match the pattern used in sdkbuild/python.go — check features/ and harness/python/ instead of '.' which scans into .venv/ and hits incompatible stubs with the pinned mypy version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The pin to 0.961 (from 2022) can't parse positional-only parameter syntax in newer google-stubs that ship with latest protobuf. Also reverts the directory-targeting workaround which didn't help. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
THardy98
force-pushed
the
feature/pull-latest-package-manager
branch
from
af7ab20 to
c94c5db
Compare
Sushisource
reviewed
Mar 11, 2026
Member
Sushisource
left a comment
Sushisource
left a comment
There was a problem hiding this comment.
Hmm... I get why we removed the lock files to allow this to work, but, ideally we want to be able to keep the various other deps locked still, since otherwise we're subject to random upgrade-related issues.
We could have the harness run the npm/uv update before executing?
Member
|
Some addtl. context to take into account: https://temporaltechnologies.slack.com/archives/C01FG4BRQVB/p1773257442027009 |
THardy98
force-pushed
the
feature/pull-latest-package-manager
branch
from
c644a4a to
16bd523
Compare
Address PR review feedback: - Replace GitHub API tag lookup with per-language package registry queries (npm, PyPI, Packagist, Maven Central, NuGet, RubyGems, Go proxy) to avoid cases where a tag exists but the package was never published - Restore lock files and use targeted SDK update commands (npm update, uv lock --upgrade-package) in CI to keep non-SDK deps stable Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
THardy98
force-pushed
the
feature/pull-latest-package-manager
branch
from
16bd523 to
10ac1cb
Compare
The Temporal PHP SDK's Testing\Environment::startRoadRunner() checks whether it started the Temporal server itself. Since the Go harness starts the server externally, this check always fails. Replace Environment with direct Symfony Process usage for RoadRunner lifecycle. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chris-olszewski
approved these changes
Mar 18, 2026
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
LGTM. One question that's just for my own curiosity and one extra condition
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
THardy98
changed the title
SDK 1.12.0 (released today) changed ActivityInfo.WorkflowId from string to string? as part of Standalone Activities support. Add null-forgiving operator since WorkflowId is always non-null inside an executing activity. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm update,uv lock --upgrade-package) in CI so non-SDK deps stay pinnedTemporal\Testing\Environmentwith directProcessusage for RoadRunner lifecycle — the Environment class's pre-flight check assumed it started the Temporal server, but the Go harness starts it externally>=1.0for compatibility with latest protobuf stubsCloses #761