fix(typescript): include @temporalio/proto for harness#790
Merged
chris-olszewski merged 1 commit intomainfrom Mar 26, 2026
Merged
fix(typescript): include @temporalio/proto for harness#790chris-olszewski merged 1 commit intomainfrom
chris-olszewski merged 1 commit intomainfrom
Conversation
THardy98
approved these changes
Mar 26, 2026
Contributor
THardy98
left a comment
There was a problem hiding this comment.
Huh, this must've been removed at some point, proto used to be part of this list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Include
@temporalio/protowhen generating the TS program from the template.Why?
Fix
tscbuild errors from missing types that now happens e.g.Got too eager in #789 and didn't do a proper clean of my features checkout. This resulted in me having
@temporalio/protoin my node_modules from some previous work and it was able to resolve when I ran the tests locally.Checklist
Closes
How was this tested:
Running test locally, but run
git clean -fdxinfeaturesto make sure you don't have junk innode_modulesthat hides errors.