Skip to content

fix(typescript): include @temporalio/proto for harness#790

Merged
chris-olszewski merged 1 commit intomainfrom
olszewski/fix_ts_build
Mar 26, 2026
Merged

fix(typescript): include @temporalio/proto for harness#790
chris-olszewski merged 1 commit intomainfrom
olszewski/fix_ts_build

Conversation

@chris-olszewski
Copy link
Copy Markdown
Member

@chris-olszewski chris-olszewski commented Mar 26, 2026

What was changed

Include @temporalio/proto when generating the TS program from the template.

Why?

Fix tsc build errors from missing types that now happens e.g.

Got too eager in #789 and didn't do a proper clean of my features checkout. This resulted in me having @temporalio/proto in my node_modules from some previous work and it was able to resolve when I ran the tests locally.

Checklist

  1. Closes

  2. How was this tested:
    Running test locally, but run git clean -fdx in features to make sure you don't have junk in node_modules that hides errors.

# Before
$ git clean -fdx
$  go run . run --lang ts --version ../typescript
...
../features/schedule/cron/feature.ts:3:26 - error TS2307: Cannot find module '@temporalio/proto' or its corresponding type declarations.

3 import { temporal } from '@temporalio/proto';
                           ~~~~~~~~~~~~~~~~~~~

../harness/ts/harness.ts:14:24 - error TS2307: Cannot find module '@temporalio/proto' or its corresponding type declarations.

14 import * as proto from '@temporalio/proto';
                          ~~~~~~~~~~~~~~~~~~~


Found 8 errors.
# With changes
$  go run . run --lang ts --version ../typescript
...
Executing feature update/deduplication
Checking result on feature update/deduplication
Using custom result checker
  1. Any docs updates needed?

@chris-olszewski chris-olszewski requested review from a team as code owners March 26, 2026 19:32
Copy link
Copy Markdown
Contributor

@THardy98 THardy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, this must've been removed at some point, proto used to be part of this list

@chris-olszewski chris-olszewski merged commit 268a6f4 into main Mar 26, 2026
26 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_ts_build branch March 26, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants