Merged
Conversation
hehaifengcn
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Updates Temporal Server to 1.29.5.
There was a breaking change in
serializationinterface: theSerializeEventsmethod previously required two arguments - and now only requires one. The second argument forEncodingTypehas been removed. As per the removal PR - "The parameter is superfluous since it always set toenumspb.ENCODING_TYPE_PROTO3. There are no plans to move to a different encoding scheme.".Why?
To ensure S2S-Proxy is up-to-date with Temporal Server versions.
Concerns
This is a breaking contract change in upstream SDK:
I believe this isn't a concern for S2S-Proxy - as we aren't impacting API surface area - it only affects internal persistence and transport interface for serialization. The serialized blob output remains the same.
Testing