Automated Testing#62
Open
tylercunnion wants to merge 23 commits into
Open
Conversation
This reverts commit ba7a25f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Adds automated testing on main and PR branches.
Linting
Adds a golangci-lint configuration synthesized from other core repos in the organization. Linters run only on code changed within the instant pull request. Linters do not run on the main branch.
Unit Testing
Unit tests run on all PR and main builds.
We collect but do not currently do anything with code coverage data. In the future we may want to integrate with Codecov, in line with some of our other projects.
Integration Testing
Integration tests use the server test environment from the OSS server repo, with the WCI component injected in. Integration tests are run against both the pinned version of the server (as defined in
go.mod) as well as the currentmainbranch (these are advisory and will not fail the build).Currently the only defined integration test is a simple smoke test to ensure we can create a worker deployment version, this will be expanded in future work.
Integration tests live in a nested submodule for dependency separation etc; there is a CI job configured to enforce that the versions defined in the respective
go.modfiles for the go language version as well as the temporal server versions stay in sync. This check will fail the build, in order to prevent drift.Why?
Enforces code standards as well as ensuring ongoing validation for the codebase.