Fix missing get_reward() method on coordinator and add reward tests#9
Merged
tempus2016 merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
async_claim_reward and async_approve_reward both called self.get_reward() which was never defined, causing an AttributeError at runtime whenever a child tried to claim a reward or a parent approved one. Also adds 12 tests covering the full reward workflow: claim (happy path, insufficient points, missing reward/child, no premature deduction), approve (deducts points, raises on insufficient balance, marks approved), and reject (removes claim, leaves points untouched). https://claude.ai/code/session_01CkPmKWe5siThpfZ6GDpNQF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async_claim_reward and async_approve_reward both called self.get_reward() which was never defined, causing an AttributeError at runtime whenever a child tried to claim a reward or a parent approved one.
Also adds 12 tests covering the full reward workflow: claim (happy path, insufficient points, missing reward/child, no premature deduction), approve (deducts points, raises on insufficient balance, marks approved), and reject (removes claim, leaves points untouched).
https://claude.ai/code/session_01CkPmKWe5siThpfZ6GDpNQF