Skip to content

fix: add the arm64 boringssl func sig pattern#25

Merged
kemingy merged 2 commits into
mainfrom
boring_arm
Apr 23, 2026
Merged

fix: add the arm64 boringssl func sig pattern#25
kemingy merged 2 commits into
mainfrom
boring_arm

Conversation

@kemingy
Copy link
Copy Markdown
Member

@kemingy kemingy commented Apr 23, 2026

No description provided.

Signed-off-by: Keming <kemingy94@gmail.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the TLS probing logic to better support arm64 by introducing architecture-specific BoringSSL byte patterns and refactoring common OpenSSL libssl path candidates into an arch-specific package.

Changes:

  • Added internal/arch with per-architecture (amd64/arm64) BoringSSL byte patterns and common libssl candidate paths.
  • Updated TLS OpenSSL and BoringSSL probe code to consume arch-specific constants instead of runtime.GOARCH switching.
  • Updated README requirements to include arm64.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tls/openssl.go Uses arch.LibSSLCandidates for OpenSSL libssl autodetection instead of a runtime GOARCH map.
tls/boring.go Uses arch.BoringSSL{Read,Write}Pattern for byte-pattern matching; removes amd64-only runtime guard.
internal/arch/const_amd64.go Adds amd64-specific BoringSSL patterns and libssl candidate paths via build tags.
internal/arch/const_arm64.go Adds arm64-specific BoringSSL patterns and libssl candidate paths via build tags.
README.md Documents arm64 as a supported runtime architecture.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread internal/arch/const_amd64.go Outdated
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy kemingy merged commit 204ffc2 into main Apr 23, 2026
3 checks passed
@kemingy kemingy deleted the boring_arm branch April 23, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants