refactor: cleanup pg/stdio ebpf functions#28
Merged
Conversation
Signed-off-by: Keming <kemingyang@tensorchord.ai>
There was a problem hiding this comment.
Pull request overview
Refactors the stdio and Postgres eBPF probes to reduce duplicated logic by extracting common “emit event” and parsing helpers, aiming to make the probe code easier to read and maintain.
Changes:
- Added a shared stdio ringbuf event emitter helper and used it from read/write tracepoints.
- Refactored Postgres startup packet detection into a helper and introduced shared event metadata/emission helpers.
- Centralized Postgres message-type filtering into a helper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
stdio/stdio.bpf.c |
Extracts duplicated ringbuf event emission into emit_stdio_event() and uses it from read/write handlers. |
postgres/pg.bpf.c |
Refactors startup detection and event emission into helpers; adjusts plaintext gating and message-type filtering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
the negotiation may fallback to plaintext Signed-off-by: Keming <kemingyang@tensorchord.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.