Match the terminal's glyph weight in diffs - #295
Merged
Conversation
AppKit smooths every glyph it draws, while Ghostty rasterizes the terminal's own and only dilates them when `font-thicken` is on — so the same face at the same size read heavier in a diff than in the terminal beside it (measured: 13.6% more ink at Berkeley Mono 16). The diff's layout manager now follows that switch, and `resolvedTerminalFont` drops its 11pt floor so a code surface keeps shrinking with the terminal it is supposed to match.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same font at the same size read heavier in a diff than in the terminal one pane over — measured at 13.6% more ink with Berkeley Mono 16. AppKit smooths every glyph it draws; Ghostty rasterizes the terminal's own and dilates them only when
font-thickenis on. Two different answers to the same question, on two surfaces sitting side by side.DiffWashLayoutManagernow follows that same switch: withThicken glyphsoff it turns font smoothing off before drawing, so one setting governs both surfaces.resolvedTerminalFontalso drops its 11pt floor, so a code surface keeps shrinking with the terminal it is meant to match.Touches the working-tree diff, the PR files diff, and the shared chrome theme.
Release Notes:
Diffs now render text at the same weight as the terminal, and follow the Thicken Glyphs setting.