Point libghostty-swift at termio-sh - #297
Open
jiweiyuan wants to merge 1 commit into
Open
Conversation
The fork moved from `jiweiyuan/libghostty-swift` to `termio-sh/libghostty-swift`, alongside the app repo. GitHub redirects the old URL, so nothing breaks unpinned — but SwiftPM records the location in both `Package.resolved` files and Xcode records it in the iOS project, and a package whose recorded identity disagrees with its declared URL is exactly the kind of thing that resolves fine locally and stalls in a release build. The dated records under docs/plan and docs/prompts keep the old name: they describe work done when that was the name.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libghostty fork now lives at termio-sh/libghostty-swift, next to the app repo. All 15 releases and their
GhosttyKit.xcframeworkassets came across, and GitHub redirects the old URL.Redirects mean nothing breaks while unpinned, but the URL is recorded in four places that resolve rather than follow links —
Package.swift, bothPackage.resolvedfiles, and the iOS project'sXCRemoteSwiftPackageReference. A package whose recorded location disagrees with its declared URL is the kind of thing that resolves fine on a dev machine and stalls in a clean CI checkout, which is the release path.Also updated:
AGENTS.md,CONTRIBUTING.md, and thecheck-ghostty-updateskill (itsFORK=variable is executable, not prose).Left alone:
docs/plan/terminal-narrow-grid-frozen-banner-fix.mdanddocs/prompts/terminal-narrow-grid-on-open-investigation.md. Those are dated records of work done when the fork had the old name.Verification
swift build— resolves from the new URL;Package.resolvedre-resolves totermio-shand stays thereswift test— 252 tests, 0 failures./scripts/build-app.sh— packaged and signedtermio.appcleanly, since the release path is the actual risk hereRelease Notes:
No user-facing change.