Skip to content

Added infor where to download validation of ImageNet#21

Merged
ternaus merged 1 commit intomainfrom
update_readme
Jan 22, 2025
Merged

Added infor where to download validation of ImageNet#21
ternaus merged 1 commit intomainfrom
update_readme

Conversation

@ternaus
Copy link
Owner

@ternaus ternaus commented Jan 22, 2025

Summary by Sourcery

Add instructions for downloading the ImageNet validation dataset.

Enhancements:

  • Update codespell to v2.4.0.

Documentation:

  • Document how to download and extract the ImageNet validation dataset.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 22, 2025

Reviewer's Guide by Sourcery

This pull request adds instructions for downloading the ImageNet validation dataset to the README. It also updates the codespell pre-commit hook to version v2.4.0.

Flow diagram for ImageNet validation dataset setup process

flowchart TD
    A[Start] --> B[Download ILSVRC2012_img_val.tar]
    B --> C[Create imagenet/val directory]
    C --> D[Extract validation images]
    D --> E[Ready for benchmarking]
    style E fill:#90EE90
Loading

File-Level Changes

Change Details Files
Added instructions for downloading the ImageNet validation dataset.
  • Added a section explaining how to download the ImageNet validation set.
  • Added bash code snippets for downloading and extracting the dataset.
README.md
Updated the codespell pre-commit hook to version v2.4.0.
  • Updated the codespell hook revision from v2.3.0 to v2.4.0.
.pre-commit-config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please add a note that ImageNet requires registration/login to download the validation set. You can mention this before the download command to set proper expectations for users.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ternaus ternaus merged commit 56aadea into main Jan 22, 2025
1 check passed
@ternaus ternaus deleted the update_readme branch January 22, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant