feat: multiple class support#9
Conversation
|
Thanks Thomas! Is there an example notebook that we could also include to demonstration how to use the multiple class functionality? |
|
@rosielickorish mind reviewing? |
|
@thomas-mattsson Have you had a chance to review the comments above. Please let me know if I can help so we can get this merged in! |
There was a problem hiding this comment.
A few updates needed before approving:
- Remove data in place of dummy data.
- Add comments to documentation describing how to use this multi-class feature
- Separate out tests for processing multi-class labels and for downloading data from multi-class labels.
- Ensure tests run offline, i.e. using dummy data or mocking the data download
|
@rosielickorish, sorry for the delay, was ooo for a couple of weeks.
|
rosielickorish
left a comment
There was a problem hiding this comment.
Hi Thomas, Changes look great, especially the new plots. I have a change set prepare to pick up on some on the points made in this review. I hope that is ok to include here. My only outstanding comment is for ensuring that we have two working negative tests for processing class labels and downloading data from class labels. If you could let me know your thoughts in this, that would be great, thank you.
|
I have pushed some changes to https://github.com/thomas-mattsson/terrakit/commits/main/ to be included in this PR. |
e4e05f4 to
f327e1e
Compare
Signed-off-by: Thomas Mattsson <thomas.mattsson@se.ibm.com>
Signed-off-by: Thomas Mattsson <thomas.mattsson@se.ibm.com>
Signed-off-by: Thomas Mattsson <thomas.mattsson@se.ibm.com>
Signed-off-by: Thomas Mattsson <thomas.mattsson@se.ibm.com>
f327e1e to
d3e904b
Compare
rosielickorish
left a comment
There was a problem hiding this comment.
Looks good. Just need to update test_process_labels__with_class_zero to check that process_labels fails as expected when given incorrect or badly formatted class labels.
rosielickorish
left a comment
There was a problem hiding this comment.
Also just need to move test_download_data__class_zero_conflict_raises_error to test_download_data_invalid_params.py since it is testing invalid parameters!
Signed-off-by: Thomas Mattsson <thomas.mattsson@se.ibm.com>
|
@rosielickorish, pushed the updates to the tests according to the latest review comments. Had to clean up a bad rebase but looks good now. |
Status
READY
Description
Adds possibility to name label files with a
_CLASS_1_part to indicate the class index of the label.Which issue(s) does this pull-request fix?
Closes: #8
Checklist