Add generic data tiling wrapper to solve padding consistency#1140
Open
ahmedemam576 wants to merge 5 commits intoterrastackai:mainfrom
Open
Add generic data tiling wrapper to solve padding consistency#1140ahmedemam576 wants to merge 5 commits intoterrastackai:mainfrom
ahmedemam576 wants to merge 5 commits intoterrastackai:mainfrom
Conversation
- Implement TilingDataModuleWrapper for any LightningDataModule - Implement TiledDataset with on-the-fly tiling and disk caching - Add 16 comprehensive integration tests (all passing) - Support sliding/tumbling window modes with configurable overlap - Provide prediction stitching with smooth blending - Include end-to-end inference demo
ahmedemam576
force-pushed
the
feature/data-titling-wrapper
branch
from
930165d to
5198d8f
Compare
Collaborator
Author
|
Updated this draft PR with example cleanup and validation.
|
Collaborator
rosielickorish
left a comment
rosielickorish
left a comment
There was a problem hiding this comment.
These two pytests are failing for me with these changes:
FAILED tests/test_finetune.py::test_finetune_multiple_backbones[fit-terramind_v1_base] - RuntimeError: view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces)....
py::test_finetune_multiple_backbones_with_prediction[terramind_v1_small] - RuntimeError: view size is not compatible with input tensor's size and stride (at least one dimension spans across two contiguous subspaces)....
FAILED tests/test_finetune.
|
|
||
| **See Also:** | ||
| - TiledDataset: Underlying dataset wrapper | ||
| - docs/tiling_datamodule_wrapper.md: Comprehensive documentation |
Collaborator
There was a problem hiding this comment.
This file doesn't exist.
|
|
||
| print("=" * 70) | ||
| print("For more details, see:") | ||
| print(" docs/tiling_datamodule_wrapper.md") |
Collaborator
There was a problem hiding this comment.
This file doesn't exist.
Collaborator
Author
There was a problem hiding this comment.
Hey @rosielickorish thanks for the feedback. I am gonna fix the issues
Collaborator
There was a problem hiding this comment.
I was expected a notebook to make it easy to run through an example of tiling. Would that be more useful here than this python script? Otherwise, the docstrings in the other files give a pretty good description on how to use this.
…late function - Fix RuntimeError: 'view size is not compatible with input tensor's size and stride' in test_finetune_multiple_backbones tests - Add .contiguous() after torch.nn.functional.pad() for all tensor dimensions (2D, 3D, 4D) in custom collate function - Tensor padding can create non-contiguous memory layouts which fail on reshape - Add documentation file (was untracked) - Add Jupyter notebook tutorial demonstrating the fix and TiledDataModuleWrapper usage - Fixes issues raised by @rosielickorish in PR review
Collaborator
rosielickorish
left a comment
rosielickorish
left a comment
There was a problem hiding this comment.
Looks good. Just a few points on the notebook to clear up still. Failing tests now passing.
| "id": "0130a6d9", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "## Section 6: Summary of Fixes\n", |
Collaborator
There was a problem hiding this comment.
Why is it starting with Section 6?
| "- 3D tensors: [C, H, W]\n", | ||
| "- 4D tensors: [B, C, H, W]\n", | ||
| "\n", | ||
| "### Why This Fixes the Tests\n", |
| }, | ||
| "nbformat": 4, | ||
| "nbformat_minor": 5 | ||
| } |
Collaborator
There was a problem hiding this comment.
This is the only example in the examples/notebooks directory. All others are in example/<some_description>, so it might be best to move this to match the other examples.
…ontent - Moved notebook from examples/notebooks/ to examples/utils/ - Updated and improved notebook code content
ahmedemam576
force-pushed
the
feature/data-titling-wrapper
branch
from
07d7d22 to
c1d8a27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses both issues #1079 and #1091