Add RandomForest decoder and embedding classification datamodule#1160
Add RandomForest decoder and embedding classification datamodule#1160arishofmann wants to merge 1 commit intoterrastackai:mainfrom
Conversation
|
Hi @arishofmann, thanks a lot for opening a PR, next time feel free to also tag us as reviewers then we get a notification :) I have some high level questions:
What do you think? |
|
Hi @Isabelle-Wittmann, thanks for the review. On the embedding dataset: yeah, the generic datasets assume image I/O (GeoTIFFs, bands, transforms, spatial dims), so I made a separate one for .pt tensors. But I agree, extending the generic dataset to also handle .pt inputs would be cleaner. I can work on that. |
|
Hi @arishofmann, great - thanks a lot! For the task module, for me it would make more sense to not inherit from a TerraTorchTask but build a separate new (base) task that fits the sklearn decoders better. |
d49b2da to
ac49c3f
Compare
…classification on frozen embeddings
|
Hi @Isabelle-Wittmann , I worked through your three points:
Tested it on CCC with RF on my Finland embeddings and it runs through and produces validation metrics. |
|
Thanks a lot, looks good! I'll test it tomorrow and then merge :) |
Here is my PR for the RF decoder and embedding classification datamodule I added