Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
license-eye has totally checked 398 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 284 | 2 | 112 | 0 |
Click to see the invalid file list
- shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/MetadataImporter.java
- shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/ShapeImporter.java
shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/MetadataImporter.java
Outdated
Show resolved
Hide resolved
shogun-lib/src/main/java/de/terrestris/shogun/lib/solr/ShapeImporter.java
Outdated
Show resolved
Hide resolved
Add solr note to README Fix license headers
mholthausen
reviewed
Mar 8, 2023
| WKTWriter2 wkt = new WKTWriter2(); | ||
| doc.addField("id", String.format("%s_%s", prefix, feature.getID())); | ||
| doc.addField("category", category); | ||
| doc.addField("title", feature.getProperty("EBENE").getValue() + " " + feature.getProperty("NAME").getValue()); |
Member
There was a problem hiding this comment.
Suggested change
| doc.addField("title", feature.getProperty("EBENE").getValue() + " " + feature.getProperty("NAME").getValue()); |
Maybe remove this line as we found out that these fields are specific fields from another project?
mholthausen
approved these changes
Mar 8, 2023
Member
mholthausen
left a comment
mholthausen
left a comment
There was a problem hiding this comment.
Looks good, just one remark to a line that contains specific properties which only exist in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds two simple helper classes that import features from a shape file and metadata documents from a CSW into a solr search index.
Pull request type
Do you introduce a breaking change?
Checklist
Apache Licence Version 2.0.
mvn testlocally).