Prevent worker result reset when switching tabs#145
Open
terryspitz wants to merge 1 commit into
Open
Conversation
Only clear workerResult when the active tab changes (different content type), not on every re-generation. This prevents the canvas going blank while axes are being adjusted. https://claude.ai/code/session_01KEbz9Q4iEzm4uSiq3qWDx9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the worker result was being cleared every time the render effect ran, even when the active tab hadn't changed. This caused unnecessary re-renders and loss of cached results.
Changes
prevEffectTabRefto track the previously rendered active tabsetWorkerResult(null)calls on every render cycleImplementation Details
The fix uses a ref to compare the current
activeTabwith the previous value. The worker result is now only reset when transitioning between tabs, rather than on every render. This preserves the cached result while the user is viewing the same tab, improving performance and preventing unnecessary re-computation.https://claude.ai/code/session_01KEbz9Q4iEzm4uSiq3qWDx9