Skip to content

Fix macOS arm64 install/build: remove linux-only esbuild dep and tighten TS typing#28

Open
JeremyCavanagh wants to merge 1 commit into
tescolopio:mainfrom
JeremyCavanagh:fix/macos-arm64-install-build
Open

Fix macOS arm64 install/build: remove linux-only esbuild dep and tighten TS typing#28
JeremyCavanagh wants to merge 1 commit into
tescolopio:mainfrom
JeremyCavanagh:fix/macos-arm64-install-build

Conversation

@JeremyCavanagh

Copy link
Copy Markdown

Summary

Fixes source install/build on macOS Apple Silicon (darwin arm64).

Changes

  • package.json
    • removed linux-only @esbuild/linux-x64 from devDependencies
  • main.ts
    • proxy cast adjusted to as unknown as DataAdapter
    • import parsing now validates mountPoints array before casting
  • src/CredentialStore.ts
    • typed Electron safeStorage access (remote?.safeStorage / safeStorage)
  • src/ui/MountManagerModal.ts
    • typed Electron dialog access (remote?.dialog / dialog)

Why

@esbuild/linux-x64 in devDependencies causes npm install to fail on non-Linux hosts (EBADPLATFORM).
After install was fixed, TypeScript reported strict typing errors in the files above.

Validation

On macOS arm64:

  • npm install
  • npm run build
  • plugin loaded successfully in Obsidian ✅
  • successfully mounted a local folder (newbeans/docs) ✅
  • mount enable/disable/remove actions worked correctly ✅

@JeremyCavanagh

Copy link
Copy Markdown
Author

This pr was supported by using my AI Agent, Badger. I don't speak typescript.

@tescolopio

Copy link
Copy Markdown
Owner

Hi everyone! We are currently reviewing the backlog of issues and PRs. It has been a little while since our last update to Folder Bridge, so we are taking some time to catch up on the newest Obsidian updates, review your feedback, and get things building smoothly again. We'll be working through these and providing updates soon. Thanks for your patience and for contributing to the plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants