Add missing appendBinary() to VirtualAdapter#30
Open
numericOverflow wants to merge 1 commit into
Open
Conversation
fix compile issues where appendBinary() required by obsidian
Owner
|
Hi everyone! We are currently reviewing the backlog of issues and PRs. It has been a little while since our last update to Folder Bridge, so we are taking some time to catch up on the newest Obsidian updates, review your feedback, and get things building smoothly again. We'll be working through these and providing updates soon. Thanks for your patience and for contributing to the plugin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Obsidian's
DataAdapterinterface now requiresappendBinary().VirtualAdapterdid not implement it, causing a TypeScript build error:Changes made
Added
appendBinary(normalizedPath, data, options)toVirtualAdapter, following the same pattern as the existingappend()method: read-only guard, ignore check, visible-file check, allowlist assertion, dry-run support,fs.promises.appendFilewithBuffer.from(data), andonModifycallback. Falls through to the original adapter for non-mounted paths.Type of Change
Testing Performed
npm run buildTest Environment
OS: Win11
Obsidian Version:
Plugin Version: 2.15.3
Node.js Versionif development): 24.14.1
Checklist