Skip to content

Add missing appendBinary() to VirtualAdapter#30

Open
numericOverflow wants to merge 1 commit into
tescolopio:mainfrom
numericOverflow:add-appendBinary-to-VirtualAdapter
Open

Add missing appendBinary() to VirtualAdapter#30
numericOverflow wants to merge 1 commit into
tescolopio:mainfrom
numericOverflow:add-appendBinary-to-VirtualAdapter

Conversation

@numericOverflow

Copy link
Copy Markdown

Description

Obsidian's DataAdapter interface now requires appendBinary(). VirtualAdapter did not implement it, causing a TypeScript build error:

Property 'appendBinary' is missing in type 'VirtualAdapter' but required in type 'DataAdapter'.

Changes made

Added appendBinary(normalizedPath, data, options) to VirtualAdapter, following the same pattern as the existing append() method: read-only guard, ignore check, visible-file check, allowlist assertion, dry-run support, fs.promises.appendFile with Buffer.from(data), and onModify callback. Falls through to the original adapter for non-mounted paths.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Testing Performed

  • Built successfully with npm run build
  • No TypeScript errors
  • No ESLint warnings
  • Tested in Obsidian
  • Tested on multiple platforms (if applicable): N/A (windows only)

Test Environment

OS: Win11
Obsidian Version:
Plugin Version: 2.15.3
Node.js Versionif development): 24.14.1

Checklist

  • My code follows the project's code style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested my changes thoroughly

fix compile issues where appendBinary() required by obsidian
@tescolopio

Copy link
Copy Markdown
Owner

Hi everyone! We are currently reviewing the backlog of issues and PRs. It has been a little while since our last update to Folder Bridge, so we are taking some time to catch up on the newest Obsidian updates, review your feedback, and get things building smoothly again. We'll be working through these and providing updates soon. Thanks for your patience and for contributing to the plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants