Discard buffered frames when seeking while paused - #163
Merged
tesselode merged 2 commits intoAug 9, 2026
Conversation
Owner
|
looks good, thanks! i'll take care of the changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162
Seeking while a
StreamingSoundis paused doesn't discard the audio the decode scheduler already buffered ahead of the playhead, so frames from the old position play before any frame from the new one.This implements the
on_syncapproach you suggested in the issue:seek_toandseek_byon the handle now also notify theStreamingSound, which drains the frame ringbuffer when playback isn't advancing. The scheduler can't drain it itself, since only the consumer side can pop.Tests
seek_while_paused_discards_stale_framesreproduces the issue and fails onmainwith the original symptom.seek_while_playing_keeps_buffered_framescovers the case where draining would be wrong. Removing theis_advancingguard makes it fail with silence where audio should be.Note
handle.position()briefly reports the pre-seek position after seeking, until the scheduler pushes frames from the new position. Position is derived from the index of frames in the ringbuffer rather than from the seek itself, so this predates this change and happens onmaintoo. Mentioning it since it's adjacent, but it looked like a separate minor issue.Let me know if you'd like a changelog entry. I wasn't sure whether those get written at release time.