Add a HTML sanitizer for translated message resources - #1
Open
linxia0415 wants to merge 1 commit into
Open
Conversation
Closes #37428 Signed-off-by: Alexander Schwartz <alexander.schwartz@gmx.net>
📝 WalkthroughWalkthroughThis pull request implements HTML safety verification for Keycloak localization messages, updates message formatting patterns across theme files, modernizes TOTP setup instructions, and corrects email template HTML across 50+ localization files. The core feature adds OWASP-based HTML sanitization to validate translated content. ChangesKeycloak Theme Localization & HTML Safety Verification
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
🧹 Nitpick comments (1)
misc/theme-verifier/pom.xml (1)
75-79: ⚡ Quick winUse the repo-managed sanitizer version property instead of a literal version.
This module currently hardcodes the OWASP sanitizer version while the root build already centralizes it, which can drift over time.
Suggested diff
<dependency> <groupId>com.googlecode.owasp-java-html-sanitizer</groupId> <artifactId>owasp-java-html-sanitizer</artifactId> - <version>20240325.1</version> + <version>${owasp.html.sanitizer.version}</version> </dependency>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@misc/theme-verifier/pom.xml` around lines 75 - 79, Replace the hardcoded version for the com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer dependency with the repository-managed Maven property used in the parent POM (i.e., change the <version>20240325.1</version> to the centralized property reference like ${owasp-java-html-sanitizer.version} or the repo's canonical property name); update the dependency declaration around the artifactId "owasp-java-html-sanitizer" so it inherits the version from the parent instead of using the literal value.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@misc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.java`:
- Around line 65-80: The verifySafeHtml() method currently throws
RuntimeException when FileInputStream reading fails for the primary file and the
englishFile; update it to follow the same checked-error contract as verify() by
changing the method signature to throw MojoExecutionException and replace the
two RuntimeException throws in the catch blocks with new
MojoExecutionException(...) that include the same descriptive message and pass
the caught IOException as the cause; ensure you reference the local variables
file and englishFile in the new exception messages so logs remain informative.
In `@misc/theme-verifier/src/test/resources/illegalHtmlTag_en.properties`:
- Line 17: The fixture currently uses a malformed closing tag ("</div") which
tests syntax errors rather than the disallowed <div> element; update the
property value for the resource key (the line starting with "key=") to use a
properly closed disallowed tag, e.g. change `Some <div>tag</div` to `Some
<div>tag</div>`, so the test explicitly targets the disallowed <div> element.
In
`@themes/src/main/resources-community/theme/base/account/messages/messages_lt.properties`:
- Line 101: The value for key totpStep1 currently contains Italian text; replace
it with the correct Lithuanian string for the TOTP installation instruction
(e.g., "Įdiekite vieną iš šių programėlių savo telefone:") by updating the
totpStep1 property so it matches the surrounding Lithuanian localization and
preserves encoding/escaping conventions used in messages_lt.properties.
In
`@themes/src/main/resources-community/theme/base/account/messages/messages_zh_CN.properties`:
- Line 112: The value for the localization key totpStep1 contains Traditional
Chinese characters; update the string to use Simplified Chinese equivalents
(replace 手機→手机, 安裝→安装, 應用程式→应用程序) so the messages_zh_CN.properties entry for
totpStep1 is written in Simplified Chinese.
In
`@themes/src/main/resources-community/theme/base/email/messages/messages_da.properties`:
- Line 9: The value for the identityProviderLinkBodyHtml property contains a
stray 'n' at the start of the fourth paragraph ("<p>nHvis..."); edit the
identityProviderLinkBodyHtml string to remove that stray 'n' so the paragraph
reads "<p>Hvis du ikke vil forbinde...</p>", preserving surrounding HTML and
placeholders ({0},{1},{2},{3},{5}).
In
`@themes/src/main/resources-community/theme/base/email/messages/messages_lt.properties`:
- Line 6: The localization value for identityProviderLinkBodyHtml contains a
typo at the start ("žas pageidauja"); update the message string for
identityProviderLinkBodyHtml to begin with the correct word (e.g., "Kažkas
pageidauja...") so the sentence is complete and natural in Lithuanian; ensure
you only change the beginning word and preserve all placeholders
({0},{1},{2},{3},{4}) and HTML structure unchanged.
- Line 3: Fix the stray character in the Lithuanian email template value for the
key emailVerificationBodyHtml: remove the leading "n" before "Jei" so the
paragraph reads "<p>Jei paskyros nekūrėte, tuomet ignoruokite šį laišką.</p>"
(update the messages_lt.properties entry for emailVerificationBodyHtml
accordingly) and run a quick search of the same key to ensure no other
accidental characters exist in the translation string.
In
`@themes/src/main/resources-community/theme/base/login/messages/messages_lt.properties`:
- Line 71: The value for key loginTotpStep1 is in Italian; update the
messages_lt.properties entry for loginTotpStep1 to the correct Lithuanian
translation (e.g., "Įdiekite vieną iš šių programėlių savo telefone:") so it
matches the surrounding Lithuanian localization and preserves the same message
intent.
---
Nitpick comments:
In `@misc/theme-verifier/pom.xml`:
- Around line 75-79: Replace the hardcoded version for the
com.googlecode.owasp-java-html-sanitizer:owasp-java-html-sanitizer dependency
with the repository-managed Maven property used in the parent POM (i.e., change
the <version>20240325.1</version> to the centralized property reference like
${owasp-java-html-sanitizer.version} or the repo's canonical property name);
update the dependency declaration around the artifactId
"owasp-java-html-sanitizer" so it inherits the version from the parent instead
of using the literal value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e6e13d5a-2e23-4427-b4c3-8e8a83845c1b
📒 Files selected for processing (48)
js/apps/account-ui/maven-resources/theme/keycloak.v3/account/messages/messages_en.propertiesjs/apps/admin-ui/maven-resources-community/theme/keycloak.v2/admin/messages/messages_zh_CN.propertiesjs/apps/admin-ui/maven-resources/theme/keycloak.v2/admin/messages/messages_en.propertiesmisc/theme-verifier/pom.xmlmisc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.javamisc/theme-verifier/src/test/java/org/keycloak/themeverifier/VerifyMessagePropertiesTest.javamisc/theme-verifier/src/test/resources/changedAnchor_de.propertiesmisc/theme-verifier/src/test/resources/changedAnchor_en.propertiesmisc/theme-verifier/src/test/resources/duplicateKeys_en.propertiesmisc/theme-verifier/src/test/resources/illegalHtmlTag_en.propertiesmisc/theme-verifier/src/test/resources/noHtml_de.propertiesmisc/theme-verifier/src/test/resources/noHtml_en.propertiesthemes/src/main/resources-community/theme/base/account/messages/messages_fi.propertiesthemes/src/main/resources-community/theme/base/account/messages/messages_lt.propertiesthemes/src/main/resources-community/theme/base/account/messages/messages_sk.propertiesthemes/src/main/resources-community/theme/base/account/messages/messages_sv.propertiesthemes/src/main/resources-community/theme/base/account/messages/messages_zh_CN.propertiesthemes/src/main/resources-community/theme/base/email/messages/messages_da.propertiesthemes/src/main/resources-community/theme/base/email/messages/messages_fa.propertiesthemes/src/main/resources-community/theme/base/email/messages/messages_hu.propertiesthemes/src/main/resources-community/theme/base/email/messages/messages_lt.propertiesthemes/src/main/resources-community/theme/base/email/messages/messages_nl.propertiesthemes/src/main/resources-community/theme/base/email/messages/messages_no.propertiesthemes/src/main/resources-community/theme/base/email/messages/messages_tr.propertiesthemes/src/main/resources-community/theme/base/email/messages/messages_uk.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_ar.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_ca.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_cs.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_de.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_el.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_es.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_fa.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_fi.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_fr.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_hr.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_ka.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_ko.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_lt.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_no.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_sk.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_sv.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_th.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_tr.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_uk.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_zh_CN.propertiesthemes/src/main/resources-community/theme/base/login/messages/messages_zh_TW.propertiesthemes/src/main/resources/theme/base/admin/messages/messages_en.propertiesthemes/src/main/resources/theme/base/login/messages/messages_en.properties
Comment on lines
+65
to
+80
| private void verifySafeHtml() { | ||
| PropertyResourceBundle bundle; | ||
| try (FileInputStream fis = new FileInputStream(file)) { | ||
| bundle = new PropertyResourceBundle(fis); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("unable to read file " + file, e); | ||
| } | ||
|
|
||
| PropertyResourceBundle bundleEnglish; | ||
| String englishFile = file.getAbsolutePath().replaceAll("resources-community", "resources") | ||
| .replaceAll("_[a-zA-Z-_]*\\.properties", "_en.properties"); | ||
| try (FileInputStream fis = new FileInputStream(englishFile)) { | ||
| bundleEnglish = new PropertyResourceBundle(fis); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException("unable to read file " + englishFile, e); | ||
| } |
There was a problem hiding this comment.
Keep error handling consistent with verify()’s MojoExecutionException contract.
verifySafeHtml() throws RuntimeException for file-read failures (Line 70, Line 79), which bypasses the plugin’s checked error flow and returns inconsistent build failures.
Suggested diff
- private void verifySafeHtml() {
+ private void verifySafeHtml() throws IOException {
PropertyResourceBundle bundle;
- try (FileInputStream fis = new FileInputStream(file)) {
- bundle = new PropertyResourceBundle(fis);
- } catch (IOException e) {
- throw new RuntimeException("unable to read file " + file, e);
- }
+ try (FileInputStream fis = new FileInputStream(file)) {
+ bundle = new PropertyResourceBundle(fis);
+ }
PropertyResourceBundle bundleEnglish;
String englishFile = file.getAbsolutePath().replaceAll("resources-community", "resources")
.replaceAll("_[a-zA-Z-_]*\\.properties", "_en.properties");
- try (FileInputStream fis = new FileInputStream(englishFile)) {
- bundleEnglish = new PropertyResourceBundle(fis);
- } catch (IOException e) {
- throw new RuntimeException("unable to read file " + englishFile, e);
- }
+ try (FileInputStream fis = new FileInputStream(englishFile)) {
+ bundleEnglish = new PropertyResourceBundle(fis);
+ }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@misc/theme-verifier/src/main/java/org/keycloak/themeverifier/VerifyMessageProperties.java`
around lines 65 - 80, The verifySafeHtml() method currently throws
RuntimeException when FileInputStream reading fails for the primary file and the
englishFile; update it to follow the same checked-error contract as verify() by
changing the method signature to throw MojoExecutionException and replace the
two RuntimeException throws in the catch blocks with new
MojoExecutionException(...) that include the same descriptive message and pass
the caught IOException as the cause; ensure you reference the local variables
file and englishFile in the new exception messages so logs remain informative.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
| key=Some <div>tag</div No newline at end of file |
There was a problem hiding this comment.
Make the fixture explicitly test a disallowed tag, not malformed syntax.
Using </div (missing >) makes this case ambiguous. If the goal is “disallowed <div>”, close the tag properly for a clearer and more stable assertion target.
Suggested diff
-key=Some <div>tag</div
+key=Some <div>tag</div>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| key=Some <div>tag</div | |
| key=Some <div>tag</div> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@misc/theme-verifier/src/test/resources/illegalHtmlTag_en.properties` at line
17, The fixture currently uses a malformed closing tag ("</div") which tests
syntax errors rather than the disallowed <div> element; update the property
value for the resource key (the line starting with "key=") to use a properly
closed disallowed tag, e.g. change `Some <div>tag</div` to `Some
<div>tag</div>`, so the test explicitly targets the disallowed <div> element.
| configureAuthenticators=Sukonfigūruotas autentifikatorius | ||
| mobile=Mobilus | ||
| totpStep1=Įdiekite <a href="https://freeotp.github.io/" target="_blank">FreeOTP</a> arba Google Authenticator savo įrenginyje. Programėlės prieinamos <a href="https://play.google.com">Google Play</a> ir Apple App Store. | ||
| totpStep1=Installa una delle seguenti applicazioni sul tuo cellulare: |
There was a problem hiding this comment.
Critical: Wrong language used in Lithuanian localization.
The totpStep1 value contains Italian text ("Installa una delle seguenti applicazioni sul tuo cellulare:") instead of Lithuanian. This file is messages_lt.properties and all surrounding messages are in Lithuanian.
🌐 Proposed fix with correct Lithuanian translation
-totpStep1=Installa una delle seguenti applicazioni sul tuo cellulare:
+totpStep1=Įdiekite vieną iš šių programėlių savo mobiliajame telefone:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| totpStep1=Installa una delle seguenti applicazioni sul tuo cellulare: | |
| totpStep1=Įdiekite vieną iš šių programėlių savo mobiliajame telefone: |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@themes/src/main/resources-community/theme/base/account/messages/messages_lt.properties`
at line 101, The value for key totpStep1 currently contains Italian text;
replace it with the correct Lithuanian string for the TOTP installation
instruction (e.g., "Įdiekite vieną iš šių programėlių savo telefone:") by
updating the totpStep1 property so it matches the surrounding Lithuanian
localization and preserves encoding/escaping conventions used in
messages_lt.properties.
| configureAuthenticators=配置的认证者 | ||
| mobile=手机 | ||
| totpStep1=在你的设备上安装 <a href="https://fedorahosted.org/freeotp/" target="_blank">FreeOTP</a> 或者 Google Authenticator.两个应用可以从 <a href="https://play.google.com">Google Play</a> 和 Apple App Store下载。 | ||
| totpStep1=在您的手機上安裝以下應用程式之一： |
There was a problem hiding this comment.
Critical: Traditional Chinese characters used in Simplified Chinese file.
The totpStep1 value uses Traditional Chinese characters (手機, 應用程式, 安裝) in a Simplified Chinese file (messages_zh_CN.properties). The file should use Simplified Chinese characters.
🌐 Proposed fix with Simplified Chinese characters
-totpStep1=在您的手機上安裝以下應用程式之一：
+totpStep1=在您的手机上安装以下应用程序之一：Note: Changed 手機→手机, 安裝→安装, 應用程式→应用程序
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| totpStep1=在您的手機上安裝以下應用程式之一： | |
| totpStep1=在您的手机上安装以下应用程序之一： |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@themes/src/main/resources-community/theme/base/account/messages/messages_zh_CN.properties`
at line 112, The value for the localization key totpStep1 contains Traditional
Chinese characters; update the string to use Simplified Chinese equivalents
(replace 手機→手机, 安裝→安装, 應用程式→应用程序) so the messages_zh_CN.properties entry for
totpStep1 is written in Simplified Chinese.
| identityProviderLinkSubject=Link {0} | ||
| identityProviderLinkBody=Nogen vil forbinde din "{1}" konto med "{0}" kontoen som er tilknyttet brugeren {2}. Hvis dette var dig, bedes du klikke på forbindet herunder for at forbinde de to konti\n\n{3}\n\nDette link vil udløbe efter {5}.\n\nHvis du ikke vil forbinde disse konti, kan du bare ignore denne besked. Hvis du vælger at forbinde de to konti, kan du logge ind som {1} via {0}. | ||
| identityProviderLinkBodyHtml=<p>Nogen vil forbinde din <b>{1}</b> konto med <b>{0}</b> kontoen som er tilknyttet brugeren {2}. Hvis dette var dig, bedes du klikke på forbindet herunder for at forbinde de to konti</p><p><a href="{3}">Bekræft</a></p><p>Dette link vil udløbe efter {5}.</p><p>nHvis du ikke vil forbinde disse konti, kan du bare ignore denne besked. Hvis du vælger at forbinde de to konti, kan du logge ind som {1} via {0}. | ||
| identityProviderLinkBodyHtml=<p>Nogen vil forbinde din <b>{1}</b> konto med <b>{0}</b> kontoen som er tilknyttet brugeren {2}. Hvis dette var dig, bedes du klikke på forbindet herunder for at forbinde de to konti</p><p><a href="{3}">Bekræft</a></p><p>Dette link vil udløbe efter {5}.</p><p>nHvis du ikke vil forbinde disse konti, kan du bare ignore denne besked. Hvis du vælger at forbinde de to konti, kan du logge ind som {1} via {0}.</p> |
There was a problem hiding this comment.
Possible typo: stray 'n' character in HTML content.
The HTML contains <p>nHvis du ikke vil forbinde... where the 'n' prefix before "Hvis" appears to be a typo. This should likely be <p>Hvis du ikke vil forbinde... (without the leading 'n').
Suggested fix
-identityProviderLinkBodyHtml=<p>Nogen vil forbinde din <b>{1}</b> konto med <b>{0}</b> kontoen som er tilknyttet brugeren {2}. Hvis dette var dig, bedes du klikke på forbindet herunder for at forbinde de to konti</p><p><a href="{3}">Bekræft</a></p><p>Dette link vil udløbe efter {5}.</p><p>nHvis du ikke vil forbinde disse konti, kan du bare ignore denne besked. Hvis du vælger at forbinde de to konti, kan du logge ind som {1} via {0}.</p>
+identityProviderLinkBodyHtml=<p>Nogen vil forbinde din <b>{1}</b> konto med <b>{0}</b> kontoen som er tilknyttet brugeren {2}. Hvis dette var dig, bedes du klikke på forbindet herunder for at forbinde de to konti</p><p><a href="{3}">Bekræft</a></p><p>Dette link vil udløbe efter {5}.</p><p>Hvis du ikke vil forbinde disse konti, kan du bare ignore denne besked. Hvis du vælger at forbinde de to konti, kan du logge ind som {1} via {0}.</p>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@themes/src/main/resources-community/theme/base/email/messages/messages_da.properties`
at line 9, The value for the identityProviderLinkBodyHtml property contains a
stray 'n' at the start of the fourth paragraph ("<p>nHvis..."); edit the
identityProviderLinkBodyHtml string to remove that stray 'n' so the paragraph
reads "<p>Hvis du ikke vil forbinde...</p>", preserving surrounding HTML and
placeholders ({0},{1},{2},{3},{5}).
| emailVerificationSubject=El. pašto patvirtinimas | ||
| emailVerificationBody=Paskyra {2} sukurta naudojant šį el. pašto adresą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą\n\n{0}\n\nŠi nuoroda galioja {1} min.\n\nJei paskyros nekūrėte, tuomet ignuoruokite šį laišką. | ||
| emailVerificationBodyHtml=<p>Paskyra {2} sukurta naudojant šį el. pašto adresą. Jei tao buvote Jūs, tuomet paspauskite žemiau esančią nuorodą</p><p><a href=LT"{0}">{0}</a></p><p>Ši nuoroda galioja {1} min.</p><p>nJei paskyros nekūrėte, tuomet ignuoruokite šį laišką.</p> | ||
| emailVerificationBodyHtml=<p>Paskyra {2} sukurta naudojant šį el. pašto adresą. Jei tao buvote Jūs, tuomet paspauskite žemiau esančią nuorodą</p><p><a href="{0}">{0}</a></p><p>Ši nuoroda galioja {1} min.</p><p>nJei paskyros nekūrėte, tuomet ignuoruokite šį laišką.</p> |
There was a problem hiding this comment.
Possible typo: stray 'n' character in HTML content.
The HTML contains <p>nJei paskyros nekūrėte... where the 'n' prefix before "Jei" appears to be a typo. This should likely be <p>Jei paskyros nekūrėte... (without the leading 'n').
Suggested fix
-emailVerificationBodyHtml=<p>Paskyra {2} sukurta naudojant šį el. pašto adresą. Jei tao buvote Jūs, tuomet paspauskite žemiau esančią nuorodą</p><p><a href="{0}">{0}</a></p><p>Ši nuoroda galioja {1} min.</p><p>nJei paskyros nekūrėte, tuomet ignuoruokite šį laišką.</p>
+emailVerificationBodyHtml=<p>Paskyra {2} sukurta naudojant šį el. pašto adresą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą</p><p><a href="{0}">{0}</a></p><p>Ši nuoroda galioja {1} min.</p><p>Jei paskyros nekūrėte, tuomet ignuoruokite šį laišką.</p>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| emailVerificationBodyHtml=<p>Paskyra {2} sukurta naudojant šį el. pašto adresą. Jei tao buvote Jūs, tuomet paspauskite žemiau esančią nuorodą</p><p><a href="{0}">{0}</a></p><p>Ši nuoroda galioja {1} min.</p><p>nJei paskyros nekūrėte, tuomet ignuoruokite šį laišką.</p> | |
| emailVerificationBodyHtml=<p>Paskyra {2} sukurta naudojant šį el. pašto adresą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą</p><p><a href="{0}">{0}</a></p><p>Ši nuoroda galioja {1} min.</p><p>Jei paskyros nekūrėte, tuomet ignuoruokite šį laišką.</p> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@themes/src/main/resources-community/theme/base/email/messages/messages_lt.properties`
at line 3, Fix the stray character in the Lithuanian email template value for
the key emailVerificationBodyHtml: remove the leading "n" before "Jei" so the
paragraph reads "<p>Jei paskyros nekūrėte, tuomet ignoruokite šį laišką.</p>"
(update the messages_lt.properties entry for emailVerificationBodyHtml
accordingly) and run a quick search of the same key to ensure no other
accidental characters exist in the translation string.
| identityProviderLinkSubject=Sąsaja {0} | ||
| identityProviderLinkBody=Kažas pageidauja susieti Jūsų "{1}" paskyrą su "{0}" {2} naudotojo paskyrą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą norėdami susieti paskyras\n\n{3}\n\nŠi nuoroda galioja {4} min.\n\nJei paskyrų susieti nenorite, tuomet ignoruokite šį laišką. Jei paskyras susiesite, tuomet prie {1} galėsiste prisijungti per {0}. | ||
| identityProviderLinkBodyHtml=<p>žas pageidauja susieti Jūsų <b>{1}</b> paskyrą su <b>{0}</b> {2} naudotojo paskyrą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą norėdami susieti paskyras</p><p><a href=LT"{3}">{3}</a></p><p>Ši nuoroda galioja {4} min.</p><p>Jei paskyrų susieti nenorite, tuomet ignoruokite šį laišką. Jei paskyras susiesite, tuomet prie {1} galėsiste prisijungti per {0}.</p> | ||
| identityProviderLinkBodyHtml=<p>žas pageidauja susieti Jūsų <b>{1}</b> paskyrą su <b>{0}</b> {2} naudotojo paskyrą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą norėdami susieti paskyras</p><p><a href="{3}">{3}</a></p><p>Ši nuoroda galioja {4} min.</p><p>Jei paskyrų susieti nenorite, tuomet ignoruokite šį laišką. Jei paskyras susiesite, tuomet prie {1} galėsiste prisijungti per {0}.</p> |
There was a problem hiding this comment.
Possible typo: missing characters at beginning of sentence.
The HTML starts with žas pageidauja which appears to be missing the beginning of the word. This should likely be Kažkas pageidauja (meaning "Someone wants").
Suggested fix
-identityProviderLinkBodyHtml=<p>žas pageidauja susieti Jūsų <b>{1}</b> paskyrą su <b>{0}</b> {2} naudotojo paskyrą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą norėdami susieti paskyras</p><p><a href="{3}">{3}</a></p><p>Ši nuoroda galioja {4} min.</p><p>Jei paskyrų susieti nenorite, tuomet ignoruokite šį laišką. Jei paskyras susiesite, tuomet prie {1} galėsiste prisijungti per {0}.</p>
+identityProviderLinkBodyHtml=<p>Kažkas pageidauja susieti Jūsų <b>{1}</b> paskyrą su <b>{0}</b> {2} naudotojo paskyrą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą norėdami susieti paskyras</p><p><a href="{3}">{3}</a></p><p>Ši nuoroda galioja {4} min.</p><p>Jei paskyrų susieti nenorite, tuomet ignoruokite šį laišką. Jei paskyras susiesite, tuomet prie {1} galėsiste prisijungti per {0}.</p>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| identityProviderLinkBodyHtml=<p>žas pageidauja susieti Jūsų <b>{1}</b> paskyrą su <b>{0}</b> {2} naudotojo paskyrą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą norėdami susieti paskyras</p><p><a href="{3}">{3}</a></p><p>Ši nuoroda galioja {4} min.</p><p>Jei paskyrų susieti nenorite, tuomet ignoruokite šį laišką. Jei paskyras susiesite, tuomet prie {1} galėsiste prisijungti per {0}.</p> | |
| identityProviderLinkBodyHtml=<p>Kažkas pageidauja susieti Jūsų <b>{1}</b> paskyrą su <b>{0}</b> {2} naudotojo paskyrą. Jei tai buvote Jūs, tuomet paspauskite žemiau esančią nuorodą norėdami susieti paskyras</p><p><a href="{3}">{3}</a></p><p>Ši nuoroda galioja {4} min.</p><p>Jei paskyrų susieti nenorite, tuomet ignoruokite šį laišką. Jei paskyras susiesite, tuomet prie {1} galėsiste prisijungti per {0}.</p> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@themes/src/main/resources-community/theme/base/email/messages/messages_lt.properties`
at line 6, The localization value for identityProviderLinkBodyHtml contains a
typo at the start ("žas pageidauja"); update the message string for
identityProviderLinkBodyHtml to begin with the correct word (e.g., "Kažkas
pageidauja...") so the sentence is complete and natural in Lithuanian; ensure
you only change the beginning word and preserve all placeholders
({0},{1},{2},{3},{4}) and HTML structure unchanged.
| gssDelegationCredential=GSS prisijungimo duomenų delegavimas | ||
|
|
||
| loginTotpStep1=Įdiekite <a href="https://freeotp.github.io/" target="_blank">FreeOTP</a> arba Google Authenticator savo įrenginyje. Programėlės prieinamos <a href="https://play.google.com">Google Play</a> ir Apple App Store. | ||
| loginTotpStep1=Installa una delle seguenti applicazioni sul tuo cellulare: |
There was a problem hiding this comment.
Critical: Wrong language used in Lithuanian localization.
The loginTotpStep1 value contains Italian text ("Installa una delle seguenti applicazioni sul tuo cellulare:") instead of Lithuanian. This file is messages_lt.properties and all surrounding messages are in Lithuanian.
🌐 Proposed fix with correct Lithuanian translation
-loginTotpStep1=Installa una delle seguenti applicazioni sul tuo cellulare:
+loginTotpStep1=Įdiekite vieną iš šių programėlių savo mobiliajame telefone:📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| loginTotpStep1=Installa una delle seguenti applicazioni sul tuo cellulare: | |
| loginTotpStep1=Įdiekite vieną iš šių programėlių savo mobiliajame telefone: |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@themes/src/main/resources-community/theme/base/login/messages/messages_lt.properties`
at line 71, The value for key loginTotpStep1 is in Italian; update the
messages_lt.properties entry for loginTotpStep1 to the correct Lithuanian
translation (e.g., "Įdiekite vieną iš šių programėlių savo telefone:") so it
matches the surrounding Lithuanian localization and preserves the same message
intent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37428
Summary by CodeRabbit
Bug Fixes
Improvements