Conversation
Add rudimentary Nix shell flake
Language and grammar
seffradev
force-pushed
the
cpp-abstraction
branch
from
81c3d26 to
c4ec32e
Compare
|
@seffradev it would be great if you could merge it with main |
| tc_container_terminate(request_id); | ||
| } | ||
|
|
||
| std::expected<void, std::string> run() { |
There was a problem hiding this comment.
New to this repo but just thought I'd take a look at what this API may look like as I want to consume the library from C++.
Am I right in thinking the use of std::expected here in this header which a user is expected to include, means that the library is only usable from C++23 and above?
If so I think it may be worth reconsidering, many projects including my one are still on C++20 or C++17.
There was a problem hiding this comment.
Good suggestion! If I find the time, I could add the project zeus-cpp/expected with a compilation conditional to either use the polyfill or the standard implementation.
Another thing worth addressing is that I am currently working on an alternative library design using the builder pattern for container creation so future revisions (as this is an early draft) may change.
Thanks for your interest!
There was a problem hiding this comment.
Yes, such an polyfill backport could work.
On my own, I would have probably just used Boost:Outcome, but I am too attached to Boost from the past.
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
It would be nice to merge with main after I get #58 over the line.
I do not mind if we merge this experimental codebase first @seffradev . As long as it builds, having a boilerplate in the repo looks reasonable to me, the whole repo is experimental ATM
|
|
||
| add_library(${TARGET} INTERFACE) | ||
|
|
||
| set(CMAKE_CXX_STANDARD 23) |
There was a problem hiding this comment.
FTR I am fine with doing only 23 for now, that's not a blocker
There was a problem hiding this comment.
My biggest argument against merging what we have is that I have a redesign almost done. I just have some UB to refine away.
seffradev
force-pushed
the
cpp-abstraction
branch
2 times, most recently
from
b0f89b5 to
35d2e8c
Compare
|
OK. I am on standby. Let me know once it is ready for review/integration. And thank you! |
|
Perfect. I'm currently fighting the compiler, as I'm using a bit too modern C++ with an even more modern compiler on my machine than what's in the CI. |
seffradev
force-pushed
the
cpp-abstraction
branch
from
35d2e8c to
f691262
Compare
Dev Containersfor the win. We can update it as needed, no need to stick with older versions as of now |
oleg-nenashev
left a comment
oleg-nenashev
left a comment
There was a problem hiding this comment.
+1 for integrating. I can finish packaging on the top of it
3 participants
What does this PR do?
It implements an initial C++ adapter library design.
It depends on #53.
Why is it important?
It provides idiomatic C++, utilizing RAII patterns.
Related issues