Implement support for specifying the protocol when exposing ports#1068
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@cristianrgreco I'll hopefully get this into a publishable state very soon. It's currently logging way too much and some stuff needs cleaning up. I'm however using this version already at my job (telephony/voice engineering where UDP is quite important) for integration testing and it works quite well! Thanks for your patience. |
|
@technocidal No problem at all. Thanks for working on it! Let me know if if there's anything I can help with |
# Conflicts: # packages/testcontainers/src/generic-container/inspect-container-util-ports-exposed.ts
|
Looks like there’s a compilation issue |
Should be addressed in the latest commit |
|
Thanks @technocidal for your contribution, and patience with reviewing the PR! |
|
@cristianrgreco And thanks for your patience with all of my little mistakes and oversights and especially for your valuable feedback. Have a nice weekend! |
Relates to #556.
Follows the commonly known Docker format for specifying ports with a protocol. Backwards compatibility has been tested. If no protocol is specified, it'll default to
tcpwhich is all that was possible withtestcontainers-nodeup until now anyway.